Subject: Re: [PATCH net-next] sock: fix comment location

From: Jεan Sacren <[email-masked]>
Date: Sun, 3 May 2015 15:11:58 -0600

From: Florian Westphal <[email-masked]>
Date: Sun, 03 May 2015 23:05:34 +0200
>
> Jεan Sacren <[email-masked]> wrote:
> > From: Jean Sacren <[email-masked]>
> > 
> > The block of comment is for 'sk_incoming_cpu' rather than 'sk_txhash'.
> > Therefore, move it above "u16 sk_incoming_cpu;" where it belongs.
> 
> comment is at the right place.
> 
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > -	u16			sk_incoming_cpu;
> >  	/* 16bit hole
> >  	 * Warned : sk_incoming_cpu can be set from softirq,
> >  	 * Do not use this hole without fully understanding possible issues.
> >  	 */
> > +	u16			sk_incoming_cpu;
> 
> This hole is between sk_incoming_cpu and sk_txhash.

I'm so sorry. Thank you for teaching me. I did wish there were an empty
line below "u16 sk_incoming_cpu;"