Subject: Re: [PATCH v2 net-next 0/2] tcp: tcp_info extensions

From: Marcelo Ricardo Leitner <[email-masked]>
Date: Tue, 12 May 2015 19:21:50 -0300

On Tue, May 12, 2015 at 01:31:53PM -0700, Eric Dumazet wrote:
> On Tue, 2015-05-12 at 10:08 -0300, Marcelo Ricardo Leitner wrote:
> > On Tue, Apr 28, 2015 at 03:28:16PM -0700, Eric Dumazet wrote:
> > > As discussed during Chris Rapier presentation in Ottawa / netdev0.1,
> > > we add to tcp_info the first two fields are highly wanted.
> > > 
> > > Each field is added into a single patch for easy code review.
> > > 
> > > (Corresponding iproute2/ss patches will be sent)
> > > 
> > > Next fields will follow once consensus is reached.
> > 
> > Is tcpEStatsPerfSegsOut amongst them? I have a need for this one and can
> > submit a patch if you're not tracking it already.
> 
> Yes, along with tcpEStatsPerfSegsIn
> 
> Because tcp_info is aligned to 64bits, we cannot cook a patch simply
> adding tcpEStatsPerfSegsOut (u32), otherwise we would introduce a hole.

Oh ok, thanks for pointing this out.

> If you can cook the patch adding tcpEStatsPerfSegsOut and
> tcpEStatsPerfSegsIn, I would be very happy to review it.

Cool, will do it, thanks!

  Marcelo