Subject: Re: qla3xxx: Odd likely incorrect use of test_bit in qla3xxx.c

From: Dan Carpenter <[email-masked]>
Date: Wed, 13 May 2015 16:19:08 +0300

Good eye, Joe.

I wrote a Smatch check to find similar bugs.  They weren't any other
places which tried to do bitwise OR.  The bug that happens occasionally
is:

#define MY_FLAG BIT(1)

	if (test_bit(MY_FLAG, &map)) {
		...

It's not normally harmful if it's used consistently, but ath9k had
memory corruption because they do:

	set_bit(BIT(6), &some_unsigned_long);

Anyway, I'll send patches for the bugs I found and push the Smatch
check. Thanks!

regards,
dan carpenter