From: Jiri Pirko <jiri@resnulli•us>
To: Simon Horman <simon.horman@netronome•com>
Cc: Scott Feldman <sfeldma@gmail•com>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH v3 net-next 4/4] rocker: make rocker_port_internal_vlan_id_{get,put}() non-transactional
Date: Wed, 20 May 2015 08:02:04 +0200 [thread overview]
Message-ID: <20150520060204.GD2228@nanopsycho.orion> (raw)
In-Reply-To: <1432100902-10187-5-git-send-email-simon.horman@netronome.com>
Wed, May 20, 2015 at 07:48:22AM CEST, simon.horman@netronome•com wrote:
>The motivation for this is that rocker_port_internal_vlan_id_{get,put} appear
>to only partially implement the transaction model: memory allocation
>and freeing is transactional, but hash and bitmap manipulation is not.
>
>The latter could be fixed, however, as it is not currently exercised
>due to trans always being SWITCHDEV_TRANS_NONE it seems cleaner
>to make rocker_port_internal_vlan_id_get non-transactional.
>
>Found by inspection.
>I do not believe that this change should have any run-time effect.
>
>Fixes: c4f20321d968 ("rocker: support prepare-commit transaction model")
>Acked-by: Scott Feldman <sfeldma@gmail•com>
>Signed-off-by: Simon Horman <simon.horman@netronome•com>
Acked-by: Jiri Pirko <jiri@resnulli•us>
prev parent reply other threads:[~2015-05-20 6:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 5:48 [PATCH v3 net-next 0/4] rocker: transaction fixes Simon Horman
2015-05-20 5:48 ` [PATCH v3 net-next 1/4] rocker: do not delete fdb entries in rocker_port_fdb_flush() when preparing transactions Simon Horman
2015-05-20 6:01 ` Jiri Pirko
2015-05-20 5:48 ` [PATCH v3 net-next 2/4] rocker: do not modify fdb table in rocker_port_fdb() " Simon Horman
2015-05-20 6:01 ` Jiri Pirko
2015-05-20 5:48 ` [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes " Simon Horman
2015-05-20 6:01 ` Jiri Pirko
2015-05-20 6:15 ` Toshiaki Makita
2015-05-20 7:48 ` Simon Horman
2015-05-20 8:36 ` Toshiaki Makita
2015-05-20 8:46 ` Simon Horman
2015-05-20 11:17 ` Jiri Pirko
2015-05-20 12:57 ` Simon Horman
2015-05-20 17:37 ` Scott Feldman
2015-05-20 22:32 ` Simon Horman
2015-05-20 23:59 ` Scott Feldman
2015-05-20 5:48 ` [PATCH v3 net-next 4/4] rocker: make rocker_port_internal_vlan_id_{get,put}() non-transactional Simon Horman
2015-05-20 6:02 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520060204.GD2228@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox