From: Simon Horman <simon.horman@netronome•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Scott Feldman <sfeldma@gmail•com>, netdev@vger•kernel.org
Subject: Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter
Date: Thu, 28 May 2015 17:30:57 +0900 [thread overview]
Message-ID: <20150528083055.GA30133@vergenet.net> (raw)
In-Reply-To: <20150528061542.GA2302@nanopsycho.orion>
On Thu, May 28, 2015 at 08:15:42AM +0200, Jiri Pirko wrote:
> Thu, May 28, 2015 at 05:23:17AM CEST, simon.horman@netronome•com wrote:
> >The rocker (switch) of a rocker_port may be trivially obtained from
> >the latter it seems cleaner not to pass the former to a function when
> >the latter is being passed anyway.
>
> I don't understand reason for this patch. I like it the way it is I must
> say. + you introduce possible multiple dereference in a row in call-chain.
My main motivation is that it seems cleaner. I marked it as an RFC
as I wasn't sure if there was a particular reason that thins are how they
are. I have no objection to leaving things as they are if thats the
consensus.
next prev parent reply other threads:[~2015-05-28 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 3:23 [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter Simon Horman
2015-05-28 5:11 ` Scott Feldman
2015-05-28 6:15 ` Jiri Pirko
2015-05-28 8:30 ` Simon Horman [this message]
2015-05-28 9:18 ` David Laight
2015-05-28 15:53 ` Scott Feldman
2015-06-01 4:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528083055.GA30133@vergenet.net \
--to=simon.horman@netronome$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox