From: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>
To: Simon Guinot <simon.guinot@sequanux•org>
Cc: Andrew Lunn <andrew@lunn•ch>, Jason Cooper <jason@lakedaemon•net>,
netdev@vger•kernel.org, Vincent Donnefort <vdonnefort@gmail•com>,
Gregory Clement <gregory.clement@free-electrons•com>,
linux-arm-kernel@lists•infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370 and 38x
Date: Wed, 17 Jun 2015 22:43:53 +0200 [thread overview]
Message-ID: <20150617224353.5ec9ec9d@free-electrons.com> (raw)
In-Reply-To: <20150617172217.GY4853@kw.sim.vm.gnt>
Simon,
On Wed, 17 Jun 2015 19:22:17 +0200, Simon Guinot wrote:
> > You should add a Fixes: tag to each commit to indicate which commit is
> > being fixed by your patches.
> >
> > Also, I was a bit surprised by your statement that Armada 38x is also
> > affected by the problem, since Armada 38x is more recent than Armada
> > XP. but indeed, according to the Armada 38x datasheet:
> >
> > IPv4 and TCP/UDP over IPv4/IPv6 checksum generation on transmit
> > frames for standard Ethernet packet size
> >
> > While the Armada XP datasheet says:
> >
> > Long frames transmission (including jumbo frames), with
> > IPv4/v6/TCP/UDP checksum generation
> >
> > So it seems like you're right about this!
>
> At first, I though this was an error in the Armada 38x datasheet (maybe
> a sloppy copy/paster). Therefore I have checked on an DB-88F6820-GP
> board and then I can confirm that the Armada 38x is also affected.
Ok, so the datasheet was correct (houra!). Thanks a lot for having done
the additional testing.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-06-17 20:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 13:19 [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370 and 38x Simon Guinot
2015-06-17 13:19 ` [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell,armada-xp-neta" Simon Guinot
2015-06-17 15:12 ` Gregory CLEMENT
2015-06-17 15:15 ` [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta" Gregory CLEMENT
2015-06-17 17:01 ` Jason Cooper
2015-06-17 20:43 ` Thomas Petazzoni
2015-06-17 21:39 ` Jason Cooper
2015-06-18 7:31 ` Thomas Petazzoni
2015-06-19 12:32 ` Simon Guinot
2015-06-25 9:13 ` Simon Guinot
2015-06-25 13:20 ` Jason Cooper
2015-06-29 13:03 ` Gregory CLEMENT
2015-06-29 13:03 ` [PATCH v2 1/3] net: mvneta: introduce compatible string "marvell,armada-xp-neta" Gregory CLEMENT
2015-06-17 13:19 ` [PATCH v2 2/3] ARM: mvebu: update Ethernet compatible string for Armada XP Simon Guinot
2015-06-29 13:04 ` Gregory CLEMENT
2015-06-17 13:19 ` [PATCH v2 3/3] ARM: mvebu: disable IP checksum with jumbo frames for Armada 370 Simon Guinot
2015-06-17 15:24 ` [PATCH v2 0/3] Fix Ethernet jumbo frames support for Armada 370 and 38x Thomas Petazzoni
2015-06-17 17:22 ` Simon Guinot
2015-06-17 20:43 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617224353.5ec9ec9d@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=simon.guinot@sequanux$(echo .)org \
--cc=vdonnefort@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox