Subject: Re: [RFC PATCHv4] net: fec: Ensure clocks are enabled while using mdio bus

From: Andrew Lunn <[email-masked]>
Date: Mon, 29 Jun 2015 05:44:02 +0200

> > @@ -3496,10 +3523,11 @@ static int __maybe_unused fec_suspend(struct
> > device *dev)
> >  		netif_device_detach(ndev);
> >  		netif_tx_unlock_bh(ndev);
> >  		fec_stop(ndev);
> > -		fec_enet_clk_enable(ndev, false);
> >  		if (!(fep->wol_flag & FEC_WOL_FLAG_ENABLE))
> >  			pinctrl_pm_select_sleep_state(&fep->pdev->dev);
> >  	}
> > +
> > +	fec_enet_clk_enable(ndev, false);
> 
> Why do you move out the api from netif runnig condition ?

Ah, read the documentation again. I see my error. I thought it would
call fec_suspend() and fec_resume(). But now i see there are separate
runtime suspend and resume functions.

I will fix this.

  Andrew