From: Stephen Hemminger <stephen@networkplumber•org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Cc: netdev@vger•kernel.org, bridge@lists•linux-foundation.org,
davem@davemloft•net
Subject: Re: [PATCH net-next] bridge: mdb: add vlan support for user entries
Date: Mon, 20 Jul 2015 15:28:17 -0700 [thread overview]
Message-ID: <20150720152817.4c2f5c73@urahara> (raw)
In-Reply-To: <1436540528-42334-1-git-send-email-nikolay@cumulusnetworks.com>
On Fri, 10 Jul 2015 08:02:08 -0700
Nikolay Aleksandrov <nikolay@cumulusnetworks•com> wrote:
> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h
> index eaaea6208b42..3635b7797508 100644
> --- a/include/uapi/linux/if_bridge.h
> +++ b/include/uapi/linux/if_bridge.h
> @@ -182,6 +182,7 @@ struct br_mdb_entry {
> #define MDB_TEMPORARY 0
> #define MDB_PERMANENT 1
> __u8 state;
> + __u16 vid;
> struct {
> union {
> __be32 ip4;
You added a new field into an unused hole in a data
structure shared as part of API with user space.
This seems like it might break when newer iproute
is run on older kernels. The vid would always be 0
on show and ignored when adding entries.
next prev parent reply other threads:[~2015-07-20 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 15:02 [PATCH net-next] bridge: mdb: add vlan support for user entries Nikolay Aleksandrov
2015-07-13 21:41 ` David Miller
2015-07-20 22:28 ` Stephen Hemminger [this message]
2015-07-20 22:53 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720152817.4c2f5c73@urahara \
--to=stephen@networkplumber$(echo .)org \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox