Subject: Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

From: Marcelo Ricardo Leitner <[email-masked]>
Date: Mon, 20 Jul 2015 14:15:22 -0300

On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote:

[ snip ]

> @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev)
>  	netif_keep_dst(dev);                     ---> (a)
>  	dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
>  
> +	/* If in flow based mode, keep the dst including encapsulation
> +	 * instructions for vxlan_xmit().
> +	 */
> +	if (vxlan->flags & VXLAN_F_FLOW_BASED)
> +		netif_keep_dst(dev);             ---> (b)
> +
>  	INIT_LIST_HEAD(&vxlan->next);
>  	spin_lock_init(&vxlan->hash_lock);
>  

Sounds like after 0287587884b1 ("net: better IFF_XMIT_DST_RELEASE
support"), which introduced (a) above, (b) is not needed?

  Marcelo