From: Kalle Valo <kvalo@codeaurora•org>
To: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Cc: netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
Johannes Berg <johannes.berg@intel•com>,
Stanislaw Gruszka <sgruszka@redhat•com>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Subject: Re: [2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph
Date: Tue, 21 Jul 2015 15:08:52 +0000 (UTC) [thread overview]
Message-ID: <20150721150852.6A966141BD5@smtp.codeaurora.org> (raw)
In-Reply-To: <1437050535-22858-2-git-send-email-andriy.shevchenko@linux.intel.com>
> There is no need to use hex_dump_to_buffer() in the cases like this:
>
> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len <= 16 */
> sprintf("%s\n", outbuf);
>
> since it maybe easily converted to simple:
>
> sprintf("%*ph\n", len, buf);
>
> Note: it seems in the case the output is groupped by 2 bytes and looks like a
> typo. Thus, patch changes that to plain byte stream.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
next prev parent reply other threads:[~2015-07-21 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 12:42 [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph Andy Shevchenko
2015-07-16 12:42 ` [PATCH 2/2] iwlegacy: " Andy Shevchenko
2015-07-21 15:08 ` Kalle Valo [this message]
2015-08-04 10:47 ` [PATCH 1/2] iwlwifi: " Andy Shevchenko
[not found] ` <1438685233.29746.156.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-08-04 11:48 ` Emmanuel Grumbach
2015-08-04 11:52 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721150852.6A966141BD5@smtp.codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=johannes.berg@intel$(echo .)com \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sgruszka@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox