From: Stephen Hemminger <shemming@brocade•com>
To: Daniel Borkmann <daniel@iogearbox•net>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH iproute2] tc: fix bpf compilation with old glibc
Date: Wed, 22 Jul 2015 09:47:02 -0700 [thread overview]
Message-ID: <20150722094702.2eb3c0ea@urahara> (raw)
In-Reply-To: <19c76849dd1f4a94875b0aa5d3d7e96c@HQ1WP-EXMB12.corp.brocade.com>
On Wed, 22 Jul 2015 13:05:32 +0000
Daniel Borkmann <daniel@iogearbox•net> wrote:
> On 07/22/2015 02:29 PM, Nicolas Dichtel wrote:
> > Error was:
> > f_bpf.o: In function `bpf_parse_opt':
> > f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
> > m_bpf.o: In function `parse_bpf':
> > m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
> > collect2: error: ld returned 1 exit status
> >
> > CC: Daniel Borkmann <daniel@iogearbox•net>
> > Fixes: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env")
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
>
> Thanks Nicolas! I am thinking we should probably just stick to getenv()
> and convert these two users.
>
> Thanks,
> Daniel
Yes, please use getenv() unless there is a obvious special
security requirement involved.
next prev parent reply other threads:[~2015-07-22 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 12:29 [PATCH iproute2] tc: fix bpf compilation with old glibc Nicolas Dichtel
2015-07-22 13:05 ` Daniel Borkmann
2015-07-22 13:18 ` Nicolas Dichtel
[not found] ` <19c76849dd1f4a94875b0aa5d3d7e96c@HQ1WP-EXMB12.corp.brocade.com>
2015-07-22 16:47 ` Stephen Hemminger [this message]
2015-07-23 7:17 ` [PATCH v2 " Nicolas Dichtel
2015-07-23 7:25 ` Daniel Borkmann
2015-07-23 21:50 ` Alexei Starovoitov
2015-07-27 8:09 ` Yegor Yefremov
2015-07-27 21:36 ` [PATCH " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722094702.2eb3c0ea@urahara \
--to=shemming@brocade$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox