From: Dan Carpenter <dan.carpenter@oracle•com>
To: Dexuan Cui <decui@microsoft•com>
Cc: "pebolle@tiscali•nl" <pebolle@tiscali•nl>,
"gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>,
"jasowang@redhat•com" <jasowang@redhat•com>,
"driverdev-devel@linuxdriverproject•org"
<driverdev-devel@linuxdriverproject•org>,
"olaf@aepfle•de" <olaf@aepfle•de>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"stephen@networkplumber•org" <stephen@networkplumber•org>,
"stefanha@redhat•com" <stefanha@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"apw@canonical•com" <apw@canonical•com>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: Re: [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability
Date: Thu, 23 Jul 2015 13:24:50 +0300 [thread overview]
Message-ID: <20150723102449.GR5371@mwanda> (raw)
In-Reply-To: <20150723101057.GQ5371@mwanda>
On Thu, Jul 23, 2015 at 01:10:57PM +0300, Dan Carpenter wrote:
> In this specific case, writing it as "if (ret != 0)" caused the bug. If
> we had written it as "if (ret) return ret;" then there are no zeroes so
> wouldn't have been any temptation to return the zero instead of the ret.
I did a search to see if returning the zero instead of the ret was a
common mistake and it seems like it might be. I did:
grep 'if (ret != 0)' drivers/ -r -A1 -n | grep "return 0;" | perl -ne 's/.c-(\d+)-/.c:$1/; print'
drivers/gpu/drm/nouveau/nouveau_display.c:111 return 0;
drivers/regulator/wm8400-regulator.c:47 return 0;
drivers/platform/x86/dell-laptop.c:859 return 0;
drivers/media/dvb-frontends/dibx000_common.c:213 return 0;
drivers/media/dvb-frontends/dibx000_common.c:217 return 0;
drivers/media/dvb-frontends/dibx000_common.c:235 return 0;
drivers/media/dvb-frontends/dibx000_common.c:239 return 0;
drivers/hv/channel.c:898 return 0;
drivers/hv/channel.c:944 return 0;
A bunch of those look suspicious but I don't know the subsystems well
enough to be sure. Can you check the last two?
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-23 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 10:58 [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability Dexuan Cui
2015-07-21 14:07 ` Vitaly Kuznetsov
2015-07-22 10:09 ` Dexuan Cui
2015-07-22 10:35 ` Dan Carpenter
2015-07-23 3:05 ` Dexuan Cui
2015-07-23 10:10 ` Dan Carpenter
2015-07-23 10:24 ` Dan Carpenter [this message]
2015-07-23 11:05 ` Dexuan Cui
2015-07-24 6:27 ` Sudip Mukherjee
2015-07-24 8:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723102449.GR5371@mwanda \
--to=dan.carpenter@oracle$(echo .)com \
--cc=apw@canonical$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=driverdev-devel@linuxdriverproject$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf@aepfle$(echo .)de \
--cc=pebolle@tiscali$(echo .)nl \
--cc=stefanha@redhat$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox