From: Stephen Hemminger <stephen@networkplumber•org>
To: Francois Romieu <romieu@fr•zoreil.com>
Cc: Liviu Dudau <Liviu.Dudau@arm•com>,
Mirko Lindner <mlindner@marvell•com>,
"ryan.harkin@linaro•org" <ryan.harkin@linaro•org>,
netdev <netdev@vger•kernel.org>,
lkml <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address
Date: Wed, 5 Aug 2015 16:16:10 -0700 [thread overview]
Message-ID: <20150805161610.3bcdde98@urahara> (raw)
In-Reply-To: <20150805203342.GA26748@electric-eye.fr.zoreil.com>
Something like this:
Subject: [PATCH net-next] sky2: use random address if EEPROM is bad
On some embedded systems the EEPROM does not contain a valid MAC address.
In that case it is better to fallback to a generated mac address and
let init scripts fix the value later.
Reported-by: Liviu Dudau <Liviu.Dudau@arm•com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
--- a/drivers/net/ethernet/marvell/sky2.c 2015-05-21 15:13:03.621126050 -0700
+++ b/drivers/net/ethernet/marvell/sky2.c 2015-08-05 16:12:38.734534467 -0700
@@ -4819,6 +4819,16 @@ static struct net_device *sky2_init_netd
memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port * 8,
ETH_ALEN);
+ /* if the address is invalid, use a random value */
+ if (!is_valid_ether_addr(dev->dev_addr)) {
+ struct sockaddr sa = { AF_UNSPEC };
+
+ netdev_warn(dev,
+ "Invalid MAC address defaulting to random\n");
+ sky2_set_mac_address(dev, &sa);
+ dev->addr_assign_type |= NET_ADDR_RANDOM;
+ }
+
return dev;
}
next prev parent reply other threads:[~2015-08-05 23:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:50 [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau
2015-08-05 16:40 ` Stephen Hemminger
2015-08-05 17:16 ` Liviu Dudau
2015-08-05 20:33 ` Francois Romieu
2015-08-05 23:16 ` Stephen Hemminger [this message]
2015-08-06 0:33 ` Florian Fainelli
2015-08-11 14:35 ` [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau
2015-08-11 17:01 ` Stephen Hemminger
2015-08-12 9:30 ` Liviu Dudau
2015-08-12 15:28 ` Stephen Hemminger
2015-08-12 16:00 ` Liviu Dudau
2015-08-11 18:56 ` Sergei Shtylyov
2015-08-12 9:15 ` Liviu Dudau
[not found] ` <CAD0U-h+Lbz+bygVCaF1Ji0VPLfh9sn504rCeGigXLER+H=KnZg@mail.gmail.com>
2015-08-05 17:18 ` [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau
2015-08-06 0:32 ` David Miller
2015-08-06 10:31 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805161610.3bcdde98@urahara \
--to=stephen@networkplumber$(echo .)org \
--cc=Liviu.Dudau@arm$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mlindner@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=ryan.harkin@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox