From: Dan Carpenter <dan.carpenter@oracle•com>
To: Tetsuo Handa <penguin-kernel@I-love•SAKURA.ne.jp>
Cc: hariprasad@chelsio•com, netdev@vger•kernel.org,
kernel-janitors@vger•kernel.org
Subject: Re: [patch] cxgb4: memory corruption in debugfs
Date: Tue, 18 Aug 2015 13:38:24 +0300 [thread overview]
Message-ID: <20150818103824.GI5610@mwanda> (raw)
In-Reply-To: <201508181928.JGB95875.OHOtSVLFMFFJQO@I-love.SAKURA.ne.jp>
On Tue, Aug 18, 2015 at 07:28:53PM +0900, Tetsuo Handa wrote:
> Dan Carpenter wrote:
> > You can't use kstrtoul() with an int or it causes memory corruption.
> > Also j should be unsigned or we have underflow bugs.
> >
> > I considered changing "j" to unsigned long but everything fits in a u32.
>
> Excuse me, but kstrtouint()'s last argument is not "u32 *" but "unsigned int *".
> Aren't there architectures where sizeof(unsigned int) > sizeof(u32) ?
No.
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-18 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 9:31 [patch] cxgb4: memory corruption in debugfs Dan Carpenter
2015-08-18 10:28 ` Tetsuo Handa
2015-08-18 10:38 ` Dan Carpenter [this message]
2015-08-19 2:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818103824.GI5610@mwanda \
--to=dan.carpenter@oracle$(echo .)com \
--cc=hariprasad@chelsio$(echo .)com \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=penguin-kernel@I-love$(echo .)SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox