From: Andrew Lunn <andrew@lunn•ch>
To: Scott Feldman <sfeldma@gmail•com>
Cc: Netdev <netdev@vger•kernel.org>, "Ji??í Pírko" <jiri@resnulli•us>
Subject: Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables
Date: Tue, 18 Aug 2015 20:19:30 +0200 [thread overview]
Message-ID: <20150818181930.GK4381@lunn.ch> (raw)
In-Reply-To: <CAE4R7bAwuZkoOqO1eA9pWQ35UPiSs7-Fm+AaedVU1wwiRZ=Jwg@mail.gmail.com>
On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote:
> On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn <andrew@lunn•ch> wrote:
> > On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfeldma@gmail•com wrote:
> >> From: Scott Feldman <sfeldma@gmail•com>
> >>
> >> > tree /sys/kernel/debug/rocker
> >> /sys/kernel/debug/rocker
> >> ????????? 5254001235010000
> >> ????????? fdb_tbl
> >> ????????? internal_vlan_tbl
> >> ????????? neigh_tbl
> >> ????????? of_dpa_flow_tbl
> >> ????????? of_dpa_group_tbl
> >>
> >> 1 directory, 5 files
> >>
> >> > cat /sys/kernel/debug/rocker/5254001235010000/internal_vlan_tbl
> >> ifindex 5 ref_count 1 vlan 3843
> >> ifindex 7 ref_count 2 vlan 3840
> >> ifindex 4 ref_count 1 vlan 3842
> >>
> >> > cat /sys/kernel/debug/rocker/5254001235010000/fdb_tbl
> >> learned 1 pport 1 addr 00:02:00:00:02:00 vlan 3840
> >> learned 1 pport 2 addr 00:02:00:00:03:00 vlan 3840
> >>
> >> > cat /sys/kernel/debug/rocker/5254001235010000/neigh_tbl
> >> 11.0.0.9 dev sw1p2 ref_count 3 index 1 dst 00:02:00:00:01:00 ttl_check 1
> >> 11.0.0.1 dev sw1p1 ref_count 3 index 0 dst 00:02:00:00:00:00 ttl_check 1
> >
> > Hi Scott
> >
> > David is not so keen no debugfs stuff. He already NACKed adding more
> > than what is currently in DSA:
> >
> > https://lkml.org/lkml/2015/7/11/8
>
> That patch added writable debugfs files, which I can see might be used
> as a back-door to program hardware. That does seem bad.
I fully agreed with respect to write. But if you read the whole
message, David is also not happy with read only.
I think before you spend too much more time on this, you need some
indication from David if he is going to merge it or not.
Andrew
next prev parent reply other threads:[~2015-08-18 18:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 22:36 [PATCH net-next v3] rocker: add debugfs support to dump internal tables sfeldma
2015-08-18 5:55 ` Jiri Pirko
2015-08-18 6:14 ` Scott Feldman
2015-08-18 6:48 ` Jiri Pirko
2015-08-18 7:21 ` Scott Feldman
2015-08-18 7:52 ` Jiri Pirko
2015-08-18 18:42 ` David Miller
2015-08-18 14:01 ` Andrew Lunn
2015-08-18 17:18 ` Scott Feldman
2015-08-18 18:19 ` Andrew Lunn [this message]
2015-08-18 20:37 ` Scott Feldman
2015-08-18 20:47 ` David Miller
2015-08-19 19:46 ` Scott Feldman
2016-03-17 20:10 ` Murali Karicheri
2016-03-17 20:25 ` Andrew Lunn
2016-03-17 20:48 ` Murali Karicheri
2016-03-17 23:18 ` Florian Fainelli
2016-03-18 17:29 ` Murali Karicheri
2016-03-17 21:53 ` Ido Schimmel
2016-03-18 17:25 ` Murali Karicheri
2016-03-17 20:56 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818181930.GK4381@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox