From: Marcelo Ricardo Leitner <mleitner@redhat•com>
To: Xin Long <lucien.xin@gmail•com>
Cc: network dev <netdev@vger•kernel.org>, davem@davemloft•net
Subject: Re: [PATCH net] sctp: partial chunk should be drop without sending abort packet
Date: Mon, 24 Aug 2015 09:47:13 -0300 [thread overview]
Message-ID: <20150824124713.GZ1097@localhost.localdomain> (raw)
In-Reply-To: <88918657d985bc0e55e64ca232dcd5f2b76b7cb4.1440410910.git.lucien.xin@gmail.com>
On Mon, Aug 24, 2015 at 06:08:30PM +0800, Xin Long wrote:
> as RFC 4960, 6.10 said, *if the receiver detects a partial chunk, it MUST drop
> the chunk*, we should not send the abort. but if we put this discard to inside
> state machine, it will send abort.
>
> so we just drop the partial chunk there, never let this chunk go into the state
> machine.
>
> Signed-off-by: Xin Long <lucien.xin@gmail•com>
> ---
This is basically reverting a chunk of Daniel's and Vlad's 26b87c788100
("net: sctp: fix remote memory pressure from excessive queueing") .
Isn't it going to re-introduce the initial issue then?
> net/sctp/inqueue.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/sctp/inqueue.c b/net/sctp/inqueue.c
> index 7e8a16c..a22ca57 100644
> --- a/net/sctp/inqueue.c
> +++ b/net/sctp/inqueue.c
> @@ -183,9 +183,9 @@ struct sctp_chunk *sctp_inq_pop(struct sctp_inq *queue)
> /* This is not a singleton */
> chunk->singleton = 0;
> } else if (chunk->chunk_end > skb_tail_pointer(chunk->skb)) {
> - /* Discard inside state machine. */
> - chunk->pdiscard = 1;
> - chunk->chunk_end = skb_tail_pointer(chunk->skb);
> + sctp_chunk_free(chunk);
> + chunk = queue->in_progress = NULL;
> + return NULL;
> } else {
> /* We are at the end of the packet, so mark the chunk
> * in case we need to send a SACK.
> --
> 2.1.0
>
next prev parent reply other threads:[~2015-08-24 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 10:08 [PATCH net] sctp: partial chunk should be drop without sending abort packet Xin Long
2015-08-24 12:47 ` Marcelo Ricardo Leitner [this message]
2015-08-24 18:22 ` Daniel Borkmann
2015-08-24 18:01 ` Vlad Yasevich
2015-08-27 13:41 ` lucien xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824124713.GZ1097@localhost.localdomain \
--to=mleitner@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox