From: "John W. Linville" <linville@tuxdriver•com>
To: Pravin B Shelar <pshelar@nicira•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH v3 net-next 2/8] geneve: Use skb mark and protocol to lookup route.
Date: Wed, 26 Aug 2015 16:46:17 -0400 [thread overview]
Message-ID: <20150826204616.GC9495@tuxdriver.com> (raw)
In-Reply-To: <1440438195-5695-3-git-send-email-pshelar@nicira.com>
On Mon, Aug 24, 2015 at 10:43:09AM -0700, Pravin B Shelar wrote:
> On packet transmit path geneve need to lookup route. Following
> patch improves route lookup using more parameters.
>
> Signed-off-by: Pravin B Shelar <pshelar@nicira•com>
> Reviewed-by: Jesse Gross <jesse@nicira•com>
> Acked-by: Thomas Graf <tgraf@suug•ch>
> ---
> drivers/net/geneve.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 95e9da0..3c5b2b1 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -202,6 +202,9 @@ static netdev_tx_t geneve_xmit(struct sk_buff *skb, struct net_device *dev)
> memset(&fl4, 0, sizeof(fl4));
> fl4.flowi4_tos = RT_TOS(tos);
> fl4.daddr = geneve->remote.sin_addr.s_addr;
> + fl4.flowi4_mark = skb->mark;
> + fl4.flowi4_proto = IPPROTO_UDP;
> +
> rt = ip_route_output_key(geneve->net, &fl4);
> if (IS_ERR(rt)) {
> netdev_dbg(dev, "no route to %pI4\n", &fl4.daddr);
Acked-by: John W. Linville <linville@tuxdriver•com>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver•com might be all we have. Be ready.
next prev parent reply other threads:[~2015-08-26 21:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 17:43 [PATCH v3 net-next 0/8] Geneve: Add support for tunnel metadata mode Pravin B Shelar
2015-08-24 17:43 ` [PATCH v3 net-next 1/8] geneve: Initialize ethernet address in device setup Pravin B Shelar
2015-08-26 20:42 ` John W. Linville
2015-08-24 17:43 ` [PATCH v3 net-next 2/8] geneve: Use skb mark and protocol to lookup route Pravin B Shelar
2015-08-26 20:46 ` John W. Linville [this message]
2015-08-24 17:43 ` [PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst() Pravin B Shelar
2015-08-24 22:02 ` Jesse Gross
2015-08-25 17:46 ` Thomas Graf
2015-08-24 17:43 ` [PATCH v3 net-next 4/8] geneve: Make dst-port configurable Pravin B Shelar
2015-08-25 17:47 ` Thomas Graf
2015-08-26 20:47 ` John W. Linville
2015-08-24 17:43 ` [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata Pravin B Shelar
2015-08-25 1:42 ` Jesse Gross
2015-08-25 2:15 ` Pravin Shelar
2015-08-25 16:50 ` Jesse Gross
2015-08-25 17:48 ` Thomas Graf
2015-08-25 21:16 ` Pravin Shelar
2015-08-25 18:12 ` Thomas Graf
2015-08-24 17:43 ` [PATCH v3 net-next 6/8] openvswitch: Use Geneve device Pravin B Shelar
2015-08-25 17:48 ` Thomas Graf
2015-08-24 17:43 ` [PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module Pravin B Shelar
2015-08-25 18:19 ` Thomas Graf
2015-08-25 20:55 ` Pravin Shelar
2015-08-25 19:03 ` Jesse Gross
2015-08-25 20:54 ` Pravin Shelar
2015-08-25 21:35 ` Jesse Gross
2015-08-26 0:05 ` Pravin Shelar
2015-08-24 17:43 ` [PATCH v3 net-next 8/8] geneve: Move device hash table to geneve socket Pravin B Shelar
2015-08-26 21:14 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826204616.GC9495@tuxdriver.com \
--to=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox