From: Viresh Kumar <viresh.kumar@linaro•org>
To: Steven Rostedt <rostedt@goodmis•org>
Cc: gregkh@linuxfoundation•org, linaro-kernel@lists•linaro.org,
Rafael Wysocki <rjw@rjwysocki•net>,
sboyd@codeaurora•org, arnd@arndb•de,
Mark Brown <broonie@kernel•org>,
Akinobu Mita <akinobu.mita@gmail•com>,
Alexander Duyck <alexander.h.duyck@redhat•com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project•org>,
Andrew Morton <akpm@linux-foundation•org>,
Andy Lutomirski <luto@amacapital•net>,
Arik Nemtsov <arik@wizery•com>,
"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists•infradead.org>,
"open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER"
<ath9k-devel@lists•ath9k.org>,
Avri Altman <avri.altman@intel•com>,
"open list:B43 WIRELESS DRIVER" <b43-dev@lists•infradead.org>,
Borislav Petkov <bp@alien8•de>,
Brian Silverman <bsilver16384@gmail•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Charles Keepax <ckeepax@opensourc
Subject: Re: [PATCH V3 2/2] debugfs: don't assume sizeof(bool) to be 4 bytes
Date: Tue, 15 Sep 2015 19:42:08 +0530 [thread overview]
Message-ID: <20150915141208.GK6350@linux> (raw)
In-Reply-To: <20150915100454.70dcc04d@gandalf.local.home>
On 15-09-15, 10:04, Steven Rostedt wrote:
> On Tue, 15 Sep 2015 14:04:59 +0530
> Viresh Kumar <viresh.kumar@linaro•org> wrote:
>
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index 2614a839c60d..f11e17ad7834 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -1237,7 +1237,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
> > /* Use the global lock for all EC transactions? */
> > tmp = 0;
> > acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
> > - ec->global_lock = tmp;
> > + ec->global_lock = !!tmp;
>
> BTW, the above is equivalent if global_lock is of type bool.
Ah, yes. Thanks for letting me know (I just testedit as well).
But will it look sane enough to set a boolean to anything apart from
true/false or 1/0? Yes, it will always be set to 0/1 only, but still..
--
viresh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2015-09-15 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9b705747a138c96c26faee5218f7b47403195b28.1442305897.git.viresh.kumar@linaro.org>
[not found] ` <9b705747a138c96c26faee5218f7b47403195b28.1442305897.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-15 8:34 ` [PATCH V3 2/2] debugfs: don't assume sizeof(bool) to be 4 bytes Viresh Kumar
2015-09-15 9:13 ` Charles Keepax
[not found] ` <27d37898b4be6b9b9f31b90135f8206ca079a868.1442305897.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-15 10:37 ` Johannes Berg
[not found] ` <1442313464.1914.21.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2015-09-15 11:04 ` Viresh Kumar
2015-09-15 13:45 ` Steven Rostedt
2015-09-15 14:04 ` Viresh Kumar
[not found] ` <20150915094509.46cca84d-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-09-15 17:38 ` Linus Torvalds
2015-09-15 17:47 ` Steven Rostedt
2015-09-16 7:24 ` Borislav Petkov
2015-09-16 8:02 ` Ingo Molnar
2015-09-15 14:04 ` Steven Rostedt
2015-09-15 14:12 ` Viresh Kumar [this message]
2015-09-15 14:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915141208.GK6350@linux \
--to=viresh.kumar@linaro$(echo .)org \
--cc=akinobu.mita@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.h.duyck@redhat$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=arik@wizery$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=ath9k-devel@lists$(echo .)ath9k.org \
--cc=avri.altman@intel$(echo .)com \
--cc=b43-dev@lists$(echo .)infradead.org \
--cc=bp@alien8$(echo .)de \
--cc=broonie@kernel$(echo .)org \
--cc=bsilver16384@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=ckeepax@opensourc \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linaro-kernel@lists$(echo .)linaro.org \
--cc=luto@amacapital$(echo .)net \
--cc=rjw@rjwysocki$(echo .)net \
--cc=rostedt@goodmis$(echo .)org \
--cc=sboyd@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox