From: Andrew Lunn <andrew@lunn•ch>
To: Russell King - ARM Linux <linux@arm•linux.org.uk>
Cc: linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org
Subject: Re: DSA: phy polling
Date: Tue, 22 Sep 2015 04:14:26 +0200 [thread overview]
Message-ID: <20150922021426.GE20288@lunn.ch> (raw)
In-Reply-To: <20150914104254.GI21084@n2100.arm.linux.org.uk>
On Mon, Sep 14, 2015 at 11:42:54AM +0100, Russell King - ARM Linux wrote:
> Andrew,
>
> I think you're the current maintainer of the Marvell DSA code, as being
> the most recent author of changes to it. :)
Hi Russell
Sorry for the slow reply, i've been on vacation.
Humm, i suppose i might be the defacto Maintainer for Marvell parts,
but i've no NDA with Marvell, so no access to the data sheets etc.
> I've noticed in my testing that the Marvell DSA code seems to poll the
> internal phy link status in mv88e6xxx_poll_link(), and set the network
> device carrier status according to the results.
Peter Korsgaard comment might be correct, the switch needs to know
what the PHY has negotiated. Hence the use of the PPU. There are also
comments in the code that the PPU is needed for indirect access to the
PHY.
So we probably need to keep the PPU, but disable it from changing the
networks stacks idea of the link state, etc.
I will add this to my TODO list to play with it.
Andrew
next prev parent reply other threads:[~2015-09-22 2:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 10:42 DSA: phy polling Russell King - ARM Linux
2015-09-14 17:28 ` Florian Fainelli
2015-09-14 18:23 ` Russell King - ARM Linux
2015-09-14 22:41 ` Florian Fainelli
2015-09-15 6:32 ` Peter Korsgaard
2015-09-22 2:14 ` Andrew Lunn [this message]
2015-09-22 11:20 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922021426.GE20288@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox