From: Andrew Lunn <andrew@lunn•ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
Cc: Scott Feldman <sfeldma@gmail•com>, Jiri Pirko <jiri@resnulli•us>,
Netdev <netdev@vger•kernel.org>,
Ido Schimmel <idosch@mellanox•com>,
eladr@mellanox•com, Florian Fainelli <f.fainelli@gmail•com>,
Guenter Roeck <linux@roeck-us•net>,
"Rosen, Rami" <rami.rosen@intel•com>,
Roopa Prabhu <roopa@cumulusnetworks•com>,
Premkumar Jonnala <pjonnala@broadcom•com>,
Andy Gospodarek <gospo@cumulusnetworks•com>,
Jiri Pirko <jiri@mellanox•com>
Subject: Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add
Date: Thu, 1 Oct 2015 17:28:21 +0200 [thread overview]
Message-ID: <20151001152821.GK20219@lunn.ch> (raw)
In-Reply-To: <20151001151535.GA31603@ketchup.mtl.sfl>
> > Does this help? Maybe we should walk before running and focus on
> > getting non-batch ops working and then revisit?
>
> I agree. I understand the need for a prepare phase, but it looks like it
> exists for specific combinations, i.e. stacked and bonded devices.
>
> For basic Ethernet switch chips (even DSA), it is *for the moment* a bit
> too unnecessarily complex.
I think we are going to need it though. I have bonding on my TODO
list. That will put DSA into a stacked system.
> What I will suggest next, is to explicitly skip the prepare phase in DSA
> (with a good comment as you already suggested), and fix switchdev to
> allow drivers to return -EOPNOTSUPP from its commit phase.
The switches have a limited number of bonds, called trunks in Marvells
terminology. So we will need the prepare phase to say: Sorry, im out
of trunks, do it in software. And different chips have different
numbers of trunks, so it will need to go down into the chip driver,
the DSA layer probably cannot decide.
Andrew
next prev parent reply other threads:[~2015-10-01 15:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 8:02 [patch net-next v3 00/10] switchdev: transaction item queue and cleanup Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 01/10] switchdev: rename "trans" to "trans_ph" Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add Jiri Pirko
2015-09-25 4:36 ` Vivien Didelot
2015-09-25 5:29 ` Scott Feldman
2015-09-25 5:55 ` David Miller
2015-09-25 15:03 ` Vivien Didelot
2015-09-30 18:56 ` Vivien Didelot
2015-10-01 4:27 ` Scott Feldman
2015-10-01 15:15 ` Vivien Didelot
2015-10-01 15:28 ` Andrew Lunn [this message]
2015-10-01 16:17 ` Vivien Didelot
2015-10-01 16:26 ` Andrew Lunn
2015-10-01 17:11 ` Vivien Didelot
2015-09-24 8:02 ` [patch net-next v3 03/10] switchdev: move transaction phase enum under transaction structure Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 04/10] switchdev: add switchdev_trans_ph_prepare/commit helpers Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 05/10] rocker: push struct switchdev_trans down through rocker code Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 06/10] rocker: use switchdev transaction queue for allocated memory Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 07/10] switchdev: remove "NONE" transaction phase Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 08/10] switchdev: remove "ABORT" " Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 09/10] dsa: use prepare/commit switchdev transaction helpers Jiri Pirko
2015-09-24 8:02 ` [patch net-next v3 10/10] switchdev: reduce transaction phase enum down to a boolean Jiri Pirko
2015-09-25 3:05 ` [patch net-next v3 00/10] switchdev: transaction item queue and cleanup Scott Feldman
2015-09-25 6:00 ` David Miller
2015-09-25 6:04 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001152821.GK20219@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=eladr@mellanox$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux@roeck-us$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pjonnala@broadcom$(echo .)com \
--cc=rami.rosen@intel$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox