From: Andrew Lunn <andrew@lunn•ch>
To: Russell King <rmk+kernel@arm•linux.org.uk>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons•com>,
netdev@vger•kernel.org
Subject: Re: [RFC PATCH] net: mvneta: add ethtool statistics
Date: Tue, 6 Oct 2015 18:52:08 +0200 [thread overview]
Message-ID: <20151006165208.GE3557@lunn.ch> (raw)
In-Reply-To: <E1Zimcg-0008HA-0y@rmk-PC.arm.linux.org.uk>
On Sun, Oct 04, 2015 at 05:58:54PM +0100, Russell King wrote:
> Add support for the ethtool statistic interface, returning the full set
> of statistics which both the Armada 370 and Armada XP can support.
>
> Signed-off-by: Russell King <rmk+kernel@arm•linux.org.uk>
> ---
> Is there any standard terminology for the ethtool statistics? Are the
> names given here satisfactory?
Hi Russell
Maybe you can use the same as drivers/net/dsa/mv88e6xxx.c? Or the same
as net/ethernet/marvell/mv643xx_eth.c
At least in the Marvell drivers, there does not seem to be any
consistency. But we should try to avoid adding a third set for
Marvell, if there is no standard.
Andrew
next prev parent reply other threads:[~2015-10-06 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 16:58 [RFC PATCH] net: mvneta: add ethtool statistics Russell King
2015-10-06 16:52 ` Andrew Lunn [this message]
2015-10-06 20:41 ` [PATCH RFC] " Russell King
2015-10-07 23:03 ` Andrew Lunn
2015-10-08 8:51 ` Russell King - ARM Linux
2015-10-08 15:32 ` Andrew Lunn
2015-10-08 15:42 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006165208.GE3557@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=thomas.petazzoni@free-electrons$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox