From: Kenneth Lee <Kenneth-Lee-2012@foxmail•com>
To: Arnd Bergmann <arnd@arndb•de>
Cc: davem@davemloft•net, joe@perches•com, liguozhu@hisilicon•com,
Yisen.Zhuang@huawei•com, netdev@vger•kernel.org,
linuxarm@huawei•com, salil.mehta@huawei•com,
xuwei5@hisilicon•com, lisheng011@huawei•com,
linux-kernel@vger•kernel.org,
huangdaode <huangdaode@hisilicon•com>
Subject: Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro
Date: Thu, 15 Oct 2015 23:32:36 +0800 [thread overview]
Message-ID: <20151015153236.GA3989@kllt-03> (raw)
In-Reply-To: <6914069.XLdT9Eli48@wuerfel>
On Tue, Oct 13, 2015 at 04:18:23PM +0200, Arnd Bergmann wrote:
> Date: Tue, 13 Oct 2015 16:18:23 +0200
> From: Arnd Bergmann <arnd@arndb•de>
> To: Kenneth Lee <Kenneth-Lee-2012@foxmail•com>
> Cc: davem@davemloft•net, joe@perches•com, liguozhu@hisilicon•com,
> Yisen.Zhuang@huawei•com, netdev@vger•kernel.org, linuxarm@huawei•com,
> salil.mehta@huawei•com, kenneth-lee-2012@foxmail•com,
> xuwei5@hisilicon•com, lisheng011@huawei•com, linux-kernel@vger•kernel.org,
> huangdaode <huangdaode@hisilicon•com>
> Subject: Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the
> once HANDEL_TX_MSG macro
> Message-ID: <6914069.XLdT9Eli48@wuerfel>
>
> On Tuesday 13 October 2015 21:27:12 Kenneth Lee wrote:
> >
> > Hi, Arnd,
> >
> > Thank you for the comment. Yes, the io_base is a security problem, we
> > will fix it in coming patch soon.
> >
> > But can we keep the sysfs? The interface from hnae is not used only by
> > ethernet driver but also by Open Data Plane driver. If we more it to
> > upper layers. Both drivers will have the same logic.
> >
> > So how about we just add documents to Documention/ABI?
>
> Hi Kenneth,
>
> In the end this is up to David Miller of course, but I'd say we are
> better off not introducing any ABIs for ODP prematurely.
>
> We are talking about very generic statistics data, and you should
> already provide them for the ethernet driver using the standard
> interfaces.
>
> I have not seen any discussion about adding an ODP subsystem for
> the Linux kernel, or what the API will be, but I think we should
> not export any interfaces from a particular device driver directly
> but always go through a common layer here and use an extensible
> interface that can be implemented by everyone.
>
> The API has not been part of a release yet, so I'd say we should
> remove it for now. Once we have a net/odp/ directory, we can
> add a driver-independent implementation there and call it from
> the hisi driver.
>
> Arnd
Hi, Arnd,
Agree. We will remove the interface for the time being. Thank you.
--
-Kenneth Lee (Hisilicon)
next prev parent reply other threads:[~2015-10-15 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 3:23 [PATCH net-next v2 0/2] hisilicon net: fix some bugs in HNS drivers huangdaode
2015-10-12 3:23 ` [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro huangdaode
2015-10-12 3:24 ` Joe Perches
2015-10-12 3:38 ` huangdaode
2015-10-12 11:53 ` Arnd Bergmann
2015-10-12 11:59 ` Arnd Bergmann
2015-10-12 16:12 ` Joe Perches
[not found] ` <561CAD6D.2060105@hisilicon.com>
2015-10-13 13:27 ` Fwd: " Kenneth Lee
2015-10-13 14:18 ` Arnd Bergmann
2015-10-15 15:32 ` Kenneth Lee [this message]
2015-10-12 3:23 ` [PATCH net-next v2 2/2] hisilicon net: fix a bug on Hisilicon Network Subsystem huangdaode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015153236.GA3989@kllt-03 \
--to=kenneth-lee-2012@foxmail$(echo .)com \
--cc=Yisen.Zhuang@huawei$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=huangdaode@hisilicon$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=liguozhu@hisilicon$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=lisheng011@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=salil.mehta@huawei$(echo .)com \
--cc=xuwei5@hisilicon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox