Subject: Fw: [Bug 106351] New: error in upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...

From: Stephen Hemminger <[email-masked]>
Date: Wed, 21 Oct 2015 09:02:46 -0700

Begin forwarded message:

Date: Tue, 20 Oct 2015 12:20:39 +0000
From: "[email-masked]" <[email-masked]>
To: "[email-masked]" <[email-masked]>
Subject: [Bug 106351] New: error in upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...

https://bugzilla.kernel.org/show_bug.cgi?id=106351

            Bug ID: 106351
           Summary: error in upstream commit
                    41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...
           Product: Networking
           Version: 2.5
    Kernel Version: 3.14
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
          Assignee: [email-masked]
          Reporter: [email-masked]
        Regression: No

Hi,
upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b has a small flaw.
Before the patch, the loop in dump_rules (line 627 - 638, fib_rules.c) was
canceled if fib_nl_fill_rule returns a value less than zero, after the patch it
is canceled if fib_nl_fill_rule returns a nonzero value. But without errors
fib_nl_fill_rule will return skb-> len. So I thing the termination condition
should be "if (err < 0) break;" not "if (err) break;".
This error leads to OOM - Exceptions in our system with program "ip"! After
changing the code to "if (err < 0) break;" everything works fine.

Regards, Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.