From: Johannes Weiner <hannes@cmpxchg•org>
To: Vladimir Davydov <vdavydov@virtuozzo•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Andrew Morton <akpm@linux-foundation•org>,
Michal Hocko <mhocko@suse•cz>, Tejun Heo <tj@kernel•org>,
netdev@vger•kernel.org, linux-mm@kvack•org,
cgroups@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 3/8] net: consolidate memcg socket buffer tracking and accounting
Date: Thu, 22 Oct 2015 15:09:43 -0400 [thread overview]
Message-ID: <20151022190943.GA20871@cmpxchg.org> (raw)
In-Reply-To: <20151022184612.GN18351@esperanza>
On Thu, Oct 22, 2015 at 09:46:12PM +0300, Vladimir Davydov wrote:
> On Thu, Oct 22, 2015 at 12:21:31AM -0400, Johannes Weiner wrote:
> > The tcp memory controller has extensive provisions for future memory
> > accounting interfaces that won't materialize after all. Cut the code
> > base down to what's actually used, now and in the likely future.
> >
> > - There won't be any different protocol counters in the future, so a
> > direct sock->sk_memcg linkage is enough. This eliminates a lot of
> > callback maze and boilerplate code, and restores most of the socket
> > allocation code to pre-tcp_memcontrol state.
> >
> > - There won't be a tcp control soft limit, so integrating the memcg
>
> In fact, the code is ready for the "soft" limit (I mean min, pressure,
> max tuple), it just lacks a knob.
Yeah, but that's not going to materialize if the entire interface for
dedicated tcp throttling is considered obsolete.
> > @@ -1136,9 +1090,6 @@ static inline bool sk_under_memory_pressure(const struct sock *sk)
> > if (!sk->sk_prot->memory_pressure)
> > return false;
> >
> > - if (mem_cgroup_sockets_enabled && sk->sk_cgrp)
> > - return !!sk->sk_cgrp->memory_pressure;
> > -
>
> AFAIU, now we won't shrink the window on hitting the limit, i.e. this
> patch subtly changes the behavior of the existing knobs, potentially
> breaking them.
Hm, but there is no grace period in which something meaningful could
happen with the window shrinking, is there? Any buffer allocation is
still going to fail hard.
I don't see how this would change anything in practice.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2015-10-22 19:09 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 4:21 [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy Johannes Weiner
2015-10-22 4:21 ` [PATCH 1/8] mm: page_counter: let page_counter_try_charge() return bool Johannes Weiner
2015-10-23 11:31 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 2/8] mm: memcontrol: export root_mem_cgroup Johannes Weiner
2015-10-23 11:32 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 3/8] net: consolidate memcg socket buffer tracking and accounting Johannes Weiner
2015-10-22 18:46 ` Vladimir Davydov
2015-10-22 19:09 ` Johannes Weiner [this message]
2015-10-23 13:42 ` Vladimir Davydov
2015-10-23 12:38 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 4/8] mm: memcontrol: prepare for unified hierarchy socket accounting Johannes Weiner
2015-10-23 12:39 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy Johannes Weiner
2015-10-22 18:47 ` Vladimir Davydov
[not found] ` <1445487696-21545-6-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-10-23 13:19 ` Michal Hocko
[not found] ` <20151023131956.GA15375-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-10-23 13:59 ` David Miller
2015-10-26 16:56 ` Johannes Weiner
2015-10-27 12:26 ` Michal Hocko
[not found] ` <20151027122647.GG9891-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-10-27 13:49 ` David Miller
2015-10-27 15:41 ` Johannes Weiner
2015-10-27 16:15 ` Michal Hocko
2015-10-27 16:42 ` Johannes Weiner
[not found] ` <20151027164227.GB7749-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-10-28 0:45 ` David Miller
2015-10-28 3:05 ` Johannes Weiner
2015-10-29 15:25 ` Michal Hocko
[not found] ` <20151029152546.GG23598-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-10-29 16:10 ` Johannes Weiner
2015-11-04 10:42 ` Michal Hocko
[not found] ` <20151104104239.GG29607-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-04 19:50 ` Johannes Weiner
2015-11-05 14:40 ` Michal Hocko
2015-11-05 16:16 ` David Miller
[not found] ` <20151105.111609.1695015438589063316.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-11-05 16:28 ` Michal Hocko
2015-11-05 16:30 ` David Miller
[not found] ` <20151105162803.GD15111-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-05 22:32 ` Johannes Weiner
2015-11-06 12:51 ` Michal Hocko
2015-11-05 20:55 ` Johannes Weiner
[not found] ` <20151105205522.GA1067-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-05 22:52 ` Johannes Weiner
2015-11-06 10:57 ` Michal Hocko
2015-11-06 16:19 ` Johannes Weiner
[not found] ` <20151106161953.GA7813-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-06 16:46 ` Michal Hocko
[not found] ` <20151106164657.GL4390-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-06 17:45 ` Johannes Weiner
2015-11-07 3:45 ` David Miller
2015-11-12 18:36 ` Mel Gorman
2015-11-12 19:12 ` Johannes Weiner
2015-11-06 9:05 ` Vladimir Davydov
2015-11-06 13:29 ` Michal Hocko
2015-11-06 16:35 ` Johannes Weiner
2015-11-06 13:21 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 6/8] mm: vmscan: simplify memcg vs. global shrinker invocation Johannes Weiner
2015-10-23 13:26 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 7/8] mm: vmscan: report vmpressure at the level of reclaim activity Johannes Weiner
[not found] ` <1445487696-21545-8-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-10-22 18:48 ` Vladimir Davydov
2015-10-23 13:49 ` Michal Hocko
2015-10-22 4:21 ` [PATCH 8/8] mm: memcontrol: hook up vmpressure to socket pressure Johannes Weiner
2015-10-22 18:57 ` Vladimir Davydov
2015-10-22 18:45 ` [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy Vladimir Davydov
2015-10-26 17:22 ` Johannes Weiner
2015-10-27 8:43 ` Vladimir Davydov
2015-10-27 16:01 ` Johannes Weiner
2015-10-28 8:20 ` Vladimir Davydov
2015-10-28 18:58 ` Johannes Weiner
2015-10-29 9:27 ` Vladimir Davydov
2015-10-29 17:52 ` Johannes Weiner
2015-11-02 14:47 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022190943.GA20871@cmpxchg.org \
--to=hannes@cmpxchg$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=mhocko@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tj@kernel$(echo .)org \
--cc=vdavydov@virtuozzo$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox