From: "Michael S. Tsirkin" <mst@redhat•com>
To: Jason Wang <jasowang@redhat•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Vlad Yasevich <vyasevic@redhat•com>
Subject: Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list
Date: Mon, 26 Oct 2015 08:09:31 +0200 [thread overview]
Message-ID: <20151026080851-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <562D9AED.4060607@redhat.com>
On Mon, Oct 26, 2015 at 11:15:57AM +0800, Jason Wang wrote:
>
>
> On 10/23/2015 09:37 PM, Michael S. Tsirkin wrote:
> > On Fri, Oct 23, 2015 at 12:57:05AM -0400, Jason Wang wrote:
> >> We don't have fraglist support in TAP_FEATURES. This will lead
> >> software segmentation of gro skb with frag list. Fixes by having
> >> frag list support in TAP_FEATURES.
> >>
> >> With this patch single session of netperf receiving were restored from
> >> about 5Gb/s to about 12Gb/s on mlx4.
> >>
> >> Fixes a567dd6252 ("macvtap: simplify usage of tap_features")
> >> Cc: Vlad Yasevich <vyasevic@redhat•com>
> >> Cc: Michael S. Tsirkin <mst@redhat•com>
> >> Signed-off-by: Jason Wang <jasowang@redhat•com>
> > Thanks!
> > Does this mean we should look at re-adding NETIF_F_FRAGLIST
> > to virtio-net as well?
>
> Not sure I get the point, but probably not. This is for receiving and
> skb_copy_datagram_iter() can deal with frag list.
Point is:
- bridge within guest
- assigned device creating gro skbs with frag list bridged to virtio
> >
> >> ---
> >> drivers/net/macvtap.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> >> index 248478c..197c939 100644
> >> --- a/drivers/net/macvtap.c
> >> +++ b/drivers/net/macvtap.c
> >> @@ -137,7 +137,7 @@ static const struct proto_ops macvtap_socket_ops;
> >> #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \
> >> NETIF_F_TSO6 | NETIF_F_UFO)
> >> #define RX_OFFLOADS (NETIF_F_GRO | NETIF_F_LRO)
> >> -#define TAP_FEATURES (NETIF_F_GSO | NETIF_F_SG)
> >> +#define TAP_FEATURES (NETIF_F_GSO | NETIF_F_SG | NETIF_F_FRAGLIST)
> >>
> >> static struct macvlan_dev *macvtap_get_vlan_rcu(const struct net_device *dev)
> >> {
> >> --
> >> 1.8.3.1
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger•kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-26 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 4:57 [PATCH net] macvtap: unbreak receiving of gro skb with frag list Jason Wang
2015-10-23 9:35 ` David Miller
2015-10-23 13:37 ` Michael S. Tsirkin
2015-10-26 3:15 ` Jason Wang
2015-10-26 6:09 ` Michael S. Tsirkin [this message]
2015-10-26 6:53 ` Jason Wang
2015-10-26 8:30 ` Michael S. Tsirkin
2015-10-27 2:58 ` Jason Wang
2015-10-27 9:05 ` Michael S. Tsirkin
2015-10-28 2:51 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026080851-mutt-send-email-mst@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox