From: Andrew Lunn <andrew@lunn•ch>
To: Neil Armstrong <narmstrong@baylibre•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>,
Guenter Roeck <linux@roeck-us•net>,
vivien.didelot@savoirfairelinux•com,
Fabian Frederick <fabf@skynet•be>,
Pavel Nakonechny <pavel.nakonechny@skitlab•ru>,
Joe Perches <joe@perches•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function
Date: Wed, 28 Oct 2015 15:45:05 +0100 [thread overview]
Message-ID: <20151028144505.GH2307@lunn.ch> (raw)
In-Reply-To: <5630DD8E.4000404@baylibre.com>
On Wed, Oct 28, 2015 at 03:37:02PM +0100, Neil Armstrong wrote:
> Hi Andrew,
>
> On 10/28/2015 03:35 PM, Andrew Lunn wrote:
> > On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote:
> >> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> >> index b1b14f5..6287096 100644
> >> --- a/drivers/net/dsa/mv88e6xxx.c
> >> +++ b/drivers/net/dsa/mv88e6xxx.c
> >> @@ -331,6 +331,16 @@ void mv88e6xxx_ppu_state_init(struct dsa_switch *ds)
> >> ps->ppu_timer.function = mv88e6xxx_ppu_reenable_timer;
> >> }
> >>
> >> +void mv88e6xxx_ppu_state_remove(struct dsa_switch *ds)
> >> +{
> >> + struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
> >> +
> >> + del_timer_sync(&ps->ppu_timer);
> >> +
> >> + cancel_work_sync(&ps->bridge_work);
> >> + flush_work(&ps->bridge_work);
> >> +}
> >> +
> >
> > You add this function, but you don't use it anywhere? Also, why
> > cancel bridge work, not ppu_work? Or has that been consolidated
> > in some patch i'm missing?
> >
> > Andrew
> >
>
> It's called in the next patch, in mv88e6131_remove for mv88e6131.
Hi Neil
It would be better to split this out into a patch of its own, and
include the mv88e6131 change with it.
Andrew
prev parent reply other threads:[~2015-10-28 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 14:13 [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function Neil Armstrong
2015-10-28 14:35 ` Andrew Lunn
2015-10-28 14:37 ` Neil Armstrong
2015-10-28 14:45 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028144505.GH2307@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fabf@skynet$(echo .)be \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=narmstrong@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel.nakonechny@skitlab$(echo .)ru \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox