From: Pablo Neira Ayuso <pablo@netfilter•org>
To: Dmitry Safonov <0x7f454c46@gmail•com>
Cc: Patrick McHardy <kaber@trash•net>,
kadlec@blackhole•kfki.hu, davem@davemloft•net,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] net: netfilter: fix GCC uninitialized warning
Date: Tue, 10 Nov 2015 13:45:53 +0100 [thread overview]
Message-ID: <20151110124553.GA22692@salvia> (raw)
In-Reply-To: <CAJwJo6Ybv9pXSFJqxtPR=W0+6JDfh8M7DtFQYV6VnuWjjWpTNA@mail.gmail.com>
On Fri, Nov 06, 2015 at 10:13:16PM +0300, Dmitry Safonov wrote:
> I thought, it was decided to use 0/NULL/whatever, than uninitialized_var()?
> Is right now?
> http://thread.gmane.org/gmane.linux.kernel/1383415
I overlook that one. We should stick to mainstream policies as much as
possible.
Arnd just sent a patch to address one of this by initializing the
variable: http://patchwork.ozlabs.org/patch/542259/
Please follow up with a patch to initialize the variable to avoid the
warning in other spots.
Thanks.
prev parent reply other threads:[~2015-11-10 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 18:48 [PATCH] net: netfilter: fix GCC uninitialized warning Dmitry Safonov
2015-11-06 19:10 ` Pablo Neira Ayuso
2015-11-06 19:07 ` [netfilter-core] " Florian Westphal
2015-11-06 19:35 ` [PATCH] net: netfilter: fix false positive GCC warnings Dmitry Safonov
2015-11-06 19:13 ` [PATCH] net: netfilter: fix GCC uninitialized warning Dmitry Safonov
2015-11-10 12:45 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110124553.GA22692@salvia \
--to=pablo@netfilter$(echo .)org \
--cc=0x7f454c46@gmail$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=kadlec@blackhole$(echo .)kfki.hu \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox