Subject: stmmac: debugfs broken with multiple ethernets.

From: Pavel Machek <[email-masked]>
Date: Mon, 23 Nov 2015 16:49:17 +0100

Hi!

stmmac_main will happily try to create two directories with the same
name.

I guess something like

static int id;
char name[100];

sprintf(name, STMMAC_RESOURCE_NAME "_%d", id++)
...

might be suitable, but did not try that further.

Best regards,

									Pavel

--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
 static int stmmac_init_fs(struct net_device *dev)
{
  -       /* Create debugfs entries */
  +       /* Create debugfs entries: FIXME: this is broken with more
  +          than one ethernet device. */
          stmmac_fs_dir = debugfs_create_dir(STMMAC_RESOURCE_NAME,
  NULL);

        if (!stmmac_fs_dir || IS_ERR(stmmac_fs_dir)) {
	
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html