Subject: Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

From: Sudip Mukherjee <[email-masked]>
Date: Wed, 25 Nov 2015 17:14:10 +0530

On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote:
> Some error handling paths are checking for success
> instead of error on rtl871x_ioctl_rtl.c.
> 
> Signed-off-by: Mauro Dreissig <[email-masked]>
> ---
>  drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 ++++++++++++++--------------
>  1 file changed, 121 insertions(+), 118 deletions(-)
> 
<snip>  
> @@ -147,13 +147,13 @@ uint oid_rt_get_rx_icv_err_hdl(struct oid_par_priv *poid_par_priv)
>  
>  	if (poid_par_priv->type_of_oid != QUERY_OID)
>  		return RNDIS_STATUS_NOT_ACCEPTED;
> -	if (poid_par_priv->information_buf_len >= sizeof(u32)) {
> -		*(uint *)poid_par_priv->information_buf =
> -					 adapter->recvpriv.rx_icv_err;
> -		*poid_par_priv->bytes_rw = poid_par_priv->information_buf_len;
> -	} else {
> +
> +	if (poid_par_priv->information_buf_len < sizeof(u32)) 

trailing whitespace here.
Please always test your patch with checkpatch.

regards
sudip