Subject: Re: [RFC 4/4] i40e: handle per queue rx_usecs setting

From: Stephen Hemminger <[email-masked]>
Date: Tue, 1 Dec 2015 11:47:26 -0800

On Tue,  1 Dec 2015 08:01:32 +0000
[email-masked] wrote:

> +u32 i40e_ndo_get_per_queue_rx_usecs(struct net_device *dev, int index)
> +{
> +	struct i40e_netdev_priv *np = netdev_priv(dev);
> +	struct i40e_vsi *vsi = np->vsi;
> +	struct i40e_pf *pf = vsi->back;
> +	struct i40e_hw *hw = &pf->hw;
> +	u32 val;
> +
> +	val = rd32(hw, I40E_PFINT_ITRN(0, index));
> +
> +	return (val * 2);

Please don't put useless paren's around return value.
That is a BSD style that is not practiced in Linux.