From: Jiri Benc <jbenc@redhat•com>
To: David Miller <davem@davemloft•net>
Cc: pshelar@nicira•com, netdev@vger•kernel.org, jesse@nicira•com
Subject: Re: [PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also for IPv6
Date: Mon, 7 Dec 2015 11:19:55 +0100 [thread overview]
Message-ID: <20151207111955.48821381@griffin> (raw)
In-Reply-To: <20151204.142838.797312333399556109.davem@davemloft.net>
On Fri, 04 Dec 2015 14:28:38 -0500 (EST), David Miller wrote:
> From: Pravin Shelar <pshelar@nicira•com>
> > Rather than checking IS_ENABLED(CONFIG_IPV6) three separate times, all
> > code can is restructured in one #if #else block by moving the ndst
> > definition to IPv6 local block.
>
> Agreed, you should be putting variable definitions into the deepest most
> containing scope anyways. So if you declare 'ndst' inside of the else
> branch you'll be doing that plus decreasing the amount of CPP tests in
> this file.
No problem. I actually had it that way but decided that I didn't like
the #if #else maze. I'll change it and send v3.
Jiri
--
Jiri Benc
prev parent reply other threads:[~2015-12-07 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 10:41 [PATCH net v2 0/2] vxlan: IPv6 fill_metadata_dst support Jiri Benc
2015-12-03 10:41 ` [PATCH net v2 1/2] vxlan: move IPv6 outpute route calculation to a function Jiri Benc
2015-12-04 18:47 ` Pravin Shelar
2015-12-03 10:41 ` [PATCH net v2 2/2] vxlan: support ndo_fill_metadata_dst also for IPv6 Jiri Benc
2015-12-04 18:49 ` Pravin Shelar
2015-12-04 19:28 ` David Miller
2015-12-07 10:19 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207111955.48821381@griffin \
--to=jbenc@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jesse@nicira$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox