From: Phil Sutter <phil@nwl•cc>
To: Daniel Borkmann <daniel@iogearbox•net>
Cc: stephen@networkplumber•org, netdev@vger•kernel.org
Subject: Re: [PATCH iproute2] ip, route: fix minor compile warning
Date: Mon, 14 Dec 2015 16:51:04 +0100 [thread overview]
Message-ID: <20151214155104.GE6555@orbit.nwl.cc> (raw)
In-Reply-To: <c43f41f31854bb0a27cc6cd6d9e465a28a94ffb9.1450106992.git.daniel@iogearbox.net>
On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote:
> Seems like gcc (4.8.3) doesn't catch this false positive, triggering
> after 0f7543322c5f ("route: ignore RTAX_HOPLIMIT of value -1"):
>
> iproute.c: In function 'print_route':
> iproute.c:301:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
> features &= ~RTAX_FEATURE_ECN;
> ^
> iproute.c:575:10: note: 'val' was declared here
> __u32 val;
> ^
> So just shut it up by initializing to 0.
Hmm. Interestingly, my patch shouldn't have changed anything relevant
for gcc's decision. OTOH, I don't see a warning using gcc-4.9.3.
Cheers, Phil
next prev parent reply other threads:[~2015-12-14 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 15:34 [PATCH iproute2] ip, route: fix minor compile warning Daniel Borkmann
2015-12-14 15:51 ` Phil Sutter [this message]
2015-12-14 15:53 ` Daniel Borkmann
2015-12-18 1:12 ` Stephen Hemminger
2015-12-18 9:18 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214155104.GE6555@orbit.nwl.cc \
--to=phil@nwl$(echo .)cc \
--cc=daniel@iogearbox$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox