From: Andrew Lunn <andrew@lunn•ch>
To: Sudip Mukherjee <sudipm.mukherjee@gmail•com>,
David Miller <davem@davemloft•net>
Cc: "David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org,
adi-buildroot-devel@lists•sourceforge.net,
netdev@vger•kernel.org
Subject: Re: [PATCH 1/2] phy: fix blackfin build failure
Date: Fri, 8 Jan 2016 16:57:23 +0100 [thread overview]
Message-ID: <20160108155723.GG4389@lunn.ch> (raw)
In-Reply-To: <1452252495-20961-1-git-send-email-sudipm.mukherjee@gmail.com>
On Fri, Jan 08, 2016 at 04:58:14PM +0530, Sudip Mukherjee wrote:
> The build of blackfin defconfig is failing with the error:
> error: 'struct mii_bus' has no member named 'phy_map'
>
> A new API mdiobus_get_phy() was introduced and phy_map was removed but
> it was not changed here.
>
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus.")
> Cc: Andrew Lunn <andrew@lunn•ch>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia•org>
> ---
Hi David.
Acked-by: Andrew Lunn <andrew@lunn•ch>
This is one more of the late 0-day reports i got. Please take these
two, along with the two fixes i posted yesterday.
Andrew
>
> build log of next-20160108 is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101006125
>
> drivers/net/ethernet/adi/bfin_mac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
> index 6286274..6f3432a 100644
> --- a/drivers/net/ethernet/adi/bfin_mac.c
> +++ b/drivers/net/ethernet/adi/bfin_mac.c
> @@ -398,7 +398,8 @@ static int mii_probe(struct net_device *dev, int phy_mode)
>
> /* search for connected PHY device */
> for (i = 0; i < PHY_MAX_ADDR; ++i) {
> - struct phy_device *const tmp_phydev = lp->mii_bus->phy_map[i];
> + struct phy_device *const tmp_phydev =
> + mdiobus_get_phy(lp->mii_bus, i);
>
> if (!tmp_phydev)
> continue; /* no PHY here... */
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-01-08 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 11:28 [PATCH 1/2] phy: fix blackfin build failure Sudip Mukherjee
2016-01-08 11:28 ` [PATCH 2/2] bfin_mac: fix error path Sudip Mukherjee
2016-01-11 3:46 ` David Miller
2016-01-08 15:57 ` Andrew Lunn [this message]
2016-01-11 3:46 ` [PATCH 1/2] phy: fix blackfin build failure David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108155723.GG4389@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sudipm.mukherjee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox