From: Jarod Wilson <jarod@redhat•com>
To: Karl Heiss <kheiss@gmail•com>
Cc: netdev@vger•kernel.org, Jay Vosburgh <j.vosburgh@gmail•com>,
Veaceslav Falico <vfalico@gmail•com>,
Andy Gospodarek <gospo@cumulusnetworks•com>
Subject: Re: [PATCH net v2] bonding: Prevent IPv6 link local address on enslaved devices
Date: Mon, 11 Jan 2016 15:11:36 -0500 [thread overview]
Message-ID: <20160111201135.GF32683@redhat.com> (raw)
In-Reply-To: <1452518923-9420-1-git-send-email-kheiss@gmail.com>
On Mon, Jan 11, 2016 at 08:28:43AM -0500, Karl Heiss wrote:
> Commit 1f718f0f4f97 ("bonding: populate neighbour's private on enslave")
> undoes the fix provided by commit c2edacf80e15 ("bonding / ipv6: no addrconf
> for slaves separately from master") by effectively setting the slave flag
> after the slave has been opened. If the slave comes up quickly enough, it
> will go through the IPv6 addrconf before the slave flag has been set and
> will get a link local IPv6 address.
>
> In order to ensure that addrconf knows to ignore the slave devices on state
> change, set IFF_SLAVE before dev_open() during bonding enslavement.
>
> Fixes: 1f718f0f4f97 ("bonding: populate neighbour's private on enslave")
>
> Signed-off-by: Karl Heiss <kheiss@gmail•com>
> ---
> - Changes since 'v1':
> - Revert clearing the IFF_SLAVE flag later during bond release so that
> RTM_NEWLINK messages will correctly reflect the slave state.
> - Update commit message for clarity.
Looks good to me as well, and I've actually got a recent Red Hat bugzilla
report about this same issue.
Reviewed-by: Jarod Wilson <jarod@redhat•com>
--
Jarod Wilson
jarod@redhat•com
next prev parent reply other threads:[~2016-01-11 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 13:28 [PATCH net v2] bonding: Prevent IPv6 link local address on enslaved devices Karl Heiss
2016-01-11 16:30 ` Jay Vosburgh
2016-01-11 20:11 ` Jarod Wilson [this message]
2016-01-11 21:08 ` Andy Gospodarek
2016-01-11 22:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111201135.GF32683@redhat.com \
--to=jarod@redhat$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=kheiss@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox