Subject: Re: [PATCH net-next 5/5] vxlan: consolidate vxlan_xmit_skb and vxlan6_xmit_skb

From: Jiri Benc <[email-masked]>
Date: Tue, 2 Feb 2016 16:06:21 +0100

On Tue, 02 Feb 2016 15:57:23 +0100, Paolo Abeni wrote:
> I think there is an issue here: in vxlan_build_skb(), 'flags' will be
> always tested against VXLAN_F_UDP_CSUM, but when tunneling over ipv6 we
> should check VXLAN_F_UDP_ZERO_CSUM6_TX instead. 

You're correct. This IPv4/v6 flags schism is a source of constant pain.
Thanks for noticing it.

> Probably an explicit 'udp_sum' argument should be added to
> vxlan_build_skb().

Yes, I'm already working on a patch and will resubmit the set.

Thanks,

 Jiri

-- 
Jiri Benc