Subject: Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities.

From: Andrew Lunn <[email-masked]>
Date: Wed, 3 Feb 2016 21:08:57 +0100

On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote:
> Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY
> compatibilities.") missed one compatible string used in in-tree DTBs:
> in OCTEON, for selected boards, the kernel DTB pruning code will overwrite
> the DTB compatible string with "marvell,88e1145", which is missing
> from the whitelist. Add it.

Does this overwriting means this compatibility is not visible in the
current DTS files? Or did i miss it?
 
At least for the Marvell SoCs i intend to submit a patch removing
these compatible strings from the DTS files. Will you do the same for
the OCTEON boards?

> The patch fixes broken networking on EdgeRouter Lite.
> 
> Fixes: ae461131960b ("of: of_mdio: Add a whitelist of PHY compatibilities.")
> Signed-off-by: Aaro Koskinen <[email-masked]>

Reviewed-by: Andrew Lunn <[email-masked]>

Thanks
	Andrew

> ---
>  drivers/of/of_mdio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 5648317..39c4be4 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -154,6 +154,7 @@ static const struct of_device_id whitelist_phys[] = {
>  	{ .compatible = "marvell,88E1111", },
>  	{ .compatible = "marvell,88e1116", },
>  	{ .compatible = "marvell,88e1118", },
> +	{ .compatible = "marvell,88e1145", },
>  	{ .compatible = "marvell,88e1149r", },
>  	{ .compatible = "marvell,88e1310", },
>  	{ .compatible = "marvell,88E1510", },
> -- 
> 2.4.0
>