Subject: Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

From: Stephen Hemminger <[email-masked]>
Date: Thu, 4 Feb 2016 10:32:26 +1100

On Wed,  3 Feb 2016 04:04:36 +0100
Nikolay Aleksandrov <[email-masked]> wrote:

>  
> +static inline int ethtool_validate_speed(__u32 speed)
> +{

No need for inline.

But why check for valid value at all. At some point in the
future, there will be yet another speed adopted by some standard body
and the switch statement would need another value.

Why not accept any value? This is a virtual device.