public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat•com>
To: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
Cc: j.vosburgh@gmail•com, netdev@vger•kernel.org
Subject: Re: [net] bonding: use return instead of goto
Date: Thu, 4 Feb 2016 14:26:22 -0500	[thread overview]
Message-ID: <20160204192622.GD50535@redhat.com> (raw)
In-Reply-To: <1454480122-32501-1-git-send-email-zhangshengju@cmss.chinamobile.com>

On Wed, Feb 03, 2016 at 06:15:22AM +0000, Zhang Shengju wrote:
> Replace 'goto' with 'return' to remove unnecessary check at label:
> err_undo_flags.

I think you're going to have to explain how you came to the conclusion
that the check isn't necessary.

-- 
Jarod Wilson
jarod@redhat•com

      reply	other threads:[~2016-02-04 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03  6:15 [net] bonding: use return instead of goto Zhang Shengju
2016-02-04 19:26 ` Jarod Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160204192622.GD50535@redhat.com \
    --to=jarod@redhat$(echo .)com \
    --cc=j.vosburgh@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=zhangshengju@cmss$(echo .)chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox