From: Andrew Lunn <andrew@lunn•ch>
To: Bryan.Whitehead@microchip•com
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver
Date: Thu, 11 Feb 2016 22:55:23 +0100 [thread overview]
Message-ID: <20160211215523.GE26333@lunn.ch> (raw)
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D264402EF4A2@CHN-SV-EXMX02.mchp-main.com>
On Thu, Feb 11, 2016 at 06:58:52PM +0000, Bryan.Whitehead@microchip•com wrote:
> This is the initial submission of an ethernet driver for
> the Microchip LAN9352.
>
> The LAN9352 is a 2-Port 10/100 Managed Ethernet Switch with
> 16-Bit Non-PCI CPU Interface. The CPU interface includes a basic
> ethernet controller interface whose virtual phy is connected
> internally to a 3rd port on the embedded switch.
>
> This driver only operates as a simple ethernet controller
> on the CPU interface. Since this interface is connected directly
> to the embedded switch, the result is that traffic can be sent and
> received on both physical ports.
>
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip•com>
> ---
> Documentation/devicetree/bindings/net/mchp9352.txt | 31 +
> MAINTAINERS | 9 +
> drivers/net/ethernet/microchip/Kconfig | 32 +-
> drivers/net/ethernet/microchip/Makefile | 1 +
> drivers/net/ethernet/microchip/mchp9352.c | 2587 ++++++++++++++++++++
> drivers/net/ethernet/microchip/mchp9352.h | 443 ++++
> 6 files changed, 3102 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/net/mchp9352.txt
> create mode 100644 drivers/net/ethernet/microchip/mchp9352.c
> create mode 100644 drivers/net/ethernet/microchip/mchp9352.h
>
> diff --git a/Documentation/devicetree/bindings/net/mchp9352.txt b/Documentation/devicetree/bindings/net/mchp9352.txt
> new file mode 100644
> index 0000000..5b22e73
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mchp9352.txt
> @@ -0,0 +1,31 @@
> +* Microchip LAN9352 Controller
> +
> +Required properties:
> +- compatible : Should be "microchip,lan9352"
> +- reg : Address and length of the io space for Microchip LAN
> +- interrupts : Should contain Microchip LAN interrupt line
> +- interrupt-parent : Should be the phandle for the interrupt controller
> + that services interrupts for this device
> +- phy-mode : See ethernet.txt file in the same directory
Hi Bryan
You still have not explained which of the two phys this phy-mode
applies to? What if i want phy #0 to be rgmii and phy #1 to be
rgmii-txid?
Andrew
next prev parent reply other threads:[~2016-02-11 21:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 18:58 [PATCH net-next,V2] Add LAN9352 Ethernet Driver Bryan.Whitehead
2016-02-11 21:55 ` Andrew Lunn [this message]
2016-02-12 16:51 ` Bryan.Whitehead
2016-02-12 17:11 ` Andrew Lunn
2016-02-16 19:34 ` Bryan.Whitehead
2016-02-16 19:51 ` David Miller
2016-02-16 20:21 ` Andrew Lunn
2016-02-12 0:14 ` Lino Sanfilippo
2016-02-12 19:10 ` Bryan.Whitehead
2016-02-16 22:09 ` Lino Sanfilippo
2016-02-12 2:18 ` Florian Fainelli
2016-02-12 7:20 ` Andrew Lunn
2016-02-12 16:53 ` Bryan.Whitehead
2016-02-12 17:18 ` Andrew Lunn
2016-02-16 19:41 ` Bryan.Whitehead
2016-02-16 19:52 ` David Miller
2016-02-16 20:36 ` Andrew Lunn
2016-02-16 20:43 ` David Miller
2016-02-16 20:48 ` Bryan.Whitehead
2016-02-16 20:52 ` David Miller
2016-02-16 21:32 ` Bryan.Whitehead
2016-02-16 21:38 ` David Miller
2016-02-16 22:15 ` Andrew Lunn
2016-02-17 0:06 ` Florian Fainelli
2016-02-17 0:31 ` Andrew Lunn
2016-02-19 19:29 ` Bryan.Whitehead
2016-02-19 20:14 ` Andrew Lunn
2016-02-19 21:21 ` Bryan.Whitehead
2016-03-24 21:16 ` Bryan.Whitehead
2016-03-24 22:06 ` Andrew Lunn
2016-03-24 22:36 ` Florian Fainelli
2016-02-16 20:57 ` Andrew Lunn
2016-02-16 21:37 ` Bryan.Whitehead
2016-02-16 21:40 ` David Miller
2016-02-12 23:21 ` Bryan.Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211215523.GE26333@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Bryan.Whitehead@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox