From: Josh Poimboeuf <jpoimboe@redhat•com>
To: Ingo Molnar <mingo@kernel•org>
Cc: Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
x86@kernel•org, linux-kernel@vger•kernel.org,
live-patching@vger•kernel.org, Michal Marek <mmarek@suse•cz>,
Peter Zijlstra <peterz@infradead•org>,
Andy Lutomirski <luto@kernel•org>, Borislav Petkov <bp@alien8•de>,
Linus Torvalds <torvalds@linux-foundation•org>,
Andi Kleen <andi@firstfloor•org>, Pedro Alves <palves@redhat•com>,
Namhyung Kim <namhyung@gmail•com>,
Bernd Petrovitsch <bernd@petrovitsch•priv.at>,
Chris J Arges <chris.j.arges@canonical•com>,
Andrew Morton <akpm@linux-foundation•org>,
Jiri Slaby <jslaby@suse•cz>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
David Vrabel <david.vrabel@citrix•com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>,
Boris Ostrovsky <boris.ostrovsky@oracle•com>,
Daniel Borkmann <daniel@iogearbox•net>,
Alexei Starovoitov <ast@k
Subject: Re: [PATCH v17 0/9] Compile-time stack metadata validation
Date: Thu, 25 Feb 2016 11:04:41 -0600 [thread overview]
Message-ID: <20160225170441.GA5763@treble.redhat.com> (raw)
In-Reply-To: <20160225080203.GC2354@gmail.com>
On Thu, Feb 25, 2016 at 09:02:04AM +0100, Ingo Molnar wrote:
>
> * Josh Poimboeuf <jpoimboe@redhat•com> wrote:
>
> > This is v17 of the compile-time stack metadata validation patch set.
> >
> > It's based on tip:x86/debug. However, note that when run against that
> > branch it will give a lot of warnings:
> >
> > objtool: arch/x86/ia32/sys_ia32.o: __ex_table size not a multiple of 12
> > objtool: arch/x86/ia32/ia32_signal.o: __ex_table size not a multiple of 12
> > objtool: arch/x86/entry/common.o: __ex_table size not a multiple of 12
> > ...
> >
> > These warnings means that objtool is expecting the new exception table
> > format which was introduced with:
> >
> > 548acf19234d ("x86/mm: Expand the exception table logic to allow new handling options")
> >
> > So that commit is needed for those warnings to go away.
>
> Ok. I have created a new topic branch for the objtool commits: tip:core/objtool,
> and merged tip:ras/core into it (which hosts 548acf19234d).
>
> So please use tip:core/objtool as a base from now on.
>
> Two more minor observations:
>
> Please re-order the patches slightly so that the annotations are added first, and
> objtool is added and Kconfig-enabled in the final patches.
>
> > x86/objtool: Compile-time stack metadata validation
> > x86/objtool: Add CONFIG_STACK_VALIDATION option
> > x86/objtool: Enable objtool on x86_64
> > x86/objtool: Add STACK_FRAME_NON_STANDARD macro
> > x86/objtool: Add directory and file whitelists
>
> btw., please use the more generic 'objtool: ' prefix, the concept is not
> fundamentally x86 specific - especially once dwarf debuginfo is interpreted it
> will be useful beyond x86 as well I suspect.
>
> > x86/xen: Add xen_cpuid() to objtool whitelist
> > bpf: Add __bpf_prog_run() to objtool whitelist
> > sched: Add __schedule() to objtool whitelist
> > x86/kprobes: Add kretprobe_trampoline() to objtool whitelist
Ok. I'll make all your suggested changes and post v18 today.
--
Josh
prev parent reply other threads:[~2016-02-25 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:36 [PATCH v17 0/9] Compile-time stack metadata validation Josh Poimboeuf
2016-02-24 16:36 ` [PATCH v17 7/9] bpf: Add __bpf_prog_run() to objtool whitelist Josh Poimboeuf
2016-02-25 8:02 ` [PATCH v17 0/9] Compile-time stack metadata validation Ingo Molnar
2016-02-25 17:04 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225170441.GA5763@treble.redhat.com \
--to=jpoimboe@redhat$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andi@firstfloor$(echo .)org \
--cc=ast@k \
--cc=bernd@petrovitsch$(echo .)priv.at \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=chris.j.arges@canonical$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=david.vrabel@citrix$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jslaby@suse$(echo .)cz \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=live-patching@vger$(echo .)kernel.org \
--cc=luto@kernel$(echo .)org \
--cc=mingo@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=mmarek@suse$(echo .)cz \
--cc=namhyung@gmail$(echo .)com \
--cc=palves@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox