From: Andrew Lunn <andrew@lunn•ch>
To: John Crispin <blogic@openwrt•org>
Cc: "Fred Chang (?????????)" <Fred.Chang@mediatek•com>,
"Steven Liu (?????????)" <steven.liu@mediatek•com>,
netdev@vger•kernel.org,
"Carlos Huang (?????????)" <Carlos.Huang@mediatek•com>,
linux-kernel@vger•kernel.org, linux-mediatek@lists•infradead.org,
Matthias Brugger <matthias.bgg@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)
Date: Fri, 26 Feb 2016 18:05:45 +0100 [thread overview]
Message-ID: <20160226170545.GE12022@lunn.ch> (raw)
In-Reply-To: <56D06E3F.1020100@openwrt.org>
> the problem here is that on one side people complain about vendors not
> sending code upstream. once they start being a good citizen and provide
> funding to send stuff upstream the feedback tends to be very bad as seen
> here. we are planning on doing a DSA driver but one step at a time. this
> kind of feedback will inevitably lead to vendors doing second thoughts
> of upstream contributions.
I think it is great a vendor is providing funding to get code
upstream. However, that code needs to conform with current kernel
architecture and design philosophy.
We as a community also need to be consistent. We have recently push
back on Microchip with there LAN9352 who want to do something very
similar, introduce the MAC and a very dumb switch driver. They are now
looking at what it means to do a DSA driver. There is also talk of
writing a DSA driver for the ks8995 family.
As David said recently, a year ago this probably would of been
accepted. But now, switches need to be DSA or switchdev.
Andrew
next prev parent reply other threads:[~2016-02-26 17:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 14:21 [PATCH V2 00/12] net-next: mediatek: add ethernet driver John Crispin
2016-02-26 14:21 ` [PATCH V2 01/12] net-next: mediatek: Document ralink/mediatek SoC ethernet binding John Crispin
[not found] ` <1456496504-50429-2-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-03-02 18:46 ` Rob Herring
2016-03-02 18:49 ` John Crispin
[not found] ` <1456496504-50429-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-02-26 14:21 ` [PATCH V2 02/12] net-next: mediatek: add the drivers core files John Crispin
2016-02-26 14:21 ` [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW) John Crispin
2016-02-26 15:18 ` Andrew Lunn
2016-02-26 15:24 ` John Crispin
2016-02-26 17:05 ` Andrew Lunn [this message]
2016-02-26 17:44 ` David Miller
2016-02-26 17:36 ` David Miller
2016-02-26 18:34 ` Florian Fainelli
2016-02-26 16:25 ` Felix Fietkau
2016-02-26 17:29 ` Andrew Lunn
2016-02-26 17:43 ` David Miller
2016-02-26 17:35 ` David Miller
2016-02-26 14:21 ` [PATCH V2 04/12] net-next: mediatek: add gigabit switch driver (GSW) John Crispin
2016-02-26 14:21 ` [PATCH V2 06/12] net-next: mediatek: add support for rt3050 John Crispin
2016-02-26 14:21 ` [PATCH V2 08/12] net-next: mediatek: add support for mt7620 John Crispin
2016-02-26 14:21 ` [PATCH V2 05/12] net-next: mediatek: add support for rt2880 John Crispin
2016-02-26 14:21 ` [PATCH V2 07/12] net-next: mediatek: add support for rt3883 John Crispin
2016-02-26 14:21 ` [PATCH V2 09/12] net-next: mediatek: add support for mt7621 John Crispin
2016-02-26 14:21 ` [PATCH V2 10/12] net-next: mediatek: add support for mt7623 John Crispin
2016-02-26 14:21 ` [PATCH V2 11/12] net-next: mediatek: add Kconfig and Makefile John Crispin
2016-02-27 3:29 ` kbuild test robot
2016-02-26 14:21 ` [PATCH V2 12/12] net-next: mediatek: add an entry to MAINTAINERS John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226170545.GE12022@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Carlos.Huang@mediatek$(echo .)com \
--cc=Fred.Chang@mediatek$(echo .)com \
--cc=blogic@openwrt$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steven.liu@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox