public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle•de>
To: Troy Kisky <troy.kisky@boundarydevices•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
	Arnd Bergmann <arnd@arndb•de>
Subject: Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT
Date: Wed, 2 Mar 2016 21:05:40 +0100	[thread overview]
Message-ID: <20160302200540.GA10722@euler.fritz.box> (raw)
In-Reply-To: <56D5CE66.3010602@boundarydevices.com>

Hi,

sorry for my late reply.

* Troy Kisky <troy.kisky@boundarydevices•com> [2016-03-01 18:16]:
>    invalid and 1 millisecond will be used instead.
> +- phy-reset-active-low : If present then the reset sequence using the GPIO
> +  specified in the "phy-reset-gpios" property is reversed (H=reset state,
> +  L=operation state).
> ____________________________
> 
> 
> Shouldn't this be named phy-reset-active-high, as you are making the reset active high
> H=reset, L= normal operation

Indeed, you're correct.

Should I send a new patch or a patch that corrects my first patch?
Because it already is in linux-next.

Regards,
Bernhard

  reply	other threads:[~2016-03-02 20:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 17:16 [PATCH] net: fec: Add "phy-reset-active-low" property to DT Troy Kisky
2016-03-02 20:05 ` Bernhard Walle [this message]
2016-03-02 20:08   ` Fabio Estevam
  -- strict thread matches above, loose matches on Subject: below --
2016-02-08 20:21 Bernhard Walle
     [not found] ` <1454962873-1941-1-git-send-email-bernhard-X9USDgGjgfuzQB+pC5nmwQ@public.gmane.org>
2016-02-08 21:46   ` Arnd Bergmann
2016-02-08 21:51     ` Andrew Lunn
2016-02-09 14:47       ` Arnd Bergmann
2016-02-08 21:48   ` Andrew Lunn
2016-02-16 20:17 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302200540.GA10722@euler.fritz.box \
    --to=bernhard@bwalle$(echo .)de \
    --cc=arnd@arndb$(echo .)de \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=troy.kisky@boundarydevices$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox