From: Andrew Lunn <andrew@lunn•ch>
To: Charles-Antoine Couret <charles-antoine.couret@nexvision•fr>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] Marvell phy: add fiber status check for some components
Date: Mon, 4 Apr 2016 14:22:19 +0200 [thread overview]
Message-ID: <20160404122219.GD21828@lunn.ch> (raw)
In-Reply-To: <570229B6.4090805@nexvision.fr>
On Mon, Apr 04, 2016 at 10:45:42AM +0200, Charles-Antoine Couret wrote:
> Hi,
>
> > Shouldn't you return to page 0, i.e. MII_M1111_COPPER, under all
> > conditions?
>
> I return marvell_read_status() which returns 0 if it hasn't error during the process.
> In case of right conditions, my function returns 0 for COPPER part (and FIBER part too).
>
> It doesn't change the value returned and behavior.
Hi Charles
Please read my email again. I'm talking about the phy page, not the
function return value.
Andrew
next prev parent reply other threads:[~2016-04-04 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 16:01 [PATCH] Marvell phy: add fiber status check for some components Charles-Antoine Couret
2016-04-01 16:33 ` Charles-Antoine Couret
2016-04-01 17:08 ` Andrew Lunn
2016-04-04 8:45 ` Charles-Antoine Couret
2016-04-04 12:22 ` Andrew Lunn [this message]
2016-04-04 13:06 ` [PATCH v2] " Charles-Antoine Couret
2016-04-04 13:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404122219.GD21828@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=charles-antoine.couret@nexvision$(echo .)fr \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox