From: Thierry Reding <thierry.reding@gmail•com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, fcooper@ti•com,
samanthakumar@google•com, Willem de Bruijn <willemb@google•com>
Subject: Re: [net-next,1/2] sunrpc: do not pull udp headers on receive
Date: Fri, 8 Apr 2016 09:47:40 +0200 [thread overview]
Message-ID: <20160408074740.GA30924@ulmo.ba.sec> (raw)
In-Reply-To: <1460043899-56894-2-git-send-email-willemdebruijn.kernel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Thu, Apr 07, 2016 at 11:44:58AM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google•com>
>
> Commit e6afc8ace6dd modified the udp receive path by pulling the udp
> header before queuing an skbuff onto the receive queue.
>
> Sunrpc also calls skb_recv_datagram to dequeue an skb from a udp
> socket. Modify this receive path to also no longer expect udp
> headers.
>
> Fixes: e6afc8ace6dd ("udp: remove headers from UDP packets before queueing")
>
> Reported-by: Franklin S Cooper Jr. <fcooper@ti•com>
> Signed-off-by: Willem de Bruijn <willemb@google•com>
> ---
> net/sunrpc/socklib.c | 2 +-
> net/sunrpc/svcsock.c | 5 ++---
> net/sunrpc/xprtsock.c | 5 ++---
> 3 files changed, 5 insertions(+), 7 deletions(-)
Applying this and patch 2/2 (along with a couple of unrelated regulator
fixes) on top of next-20160408 fixes booting from NFS root for me on
Jetson TK1. Thanks for fixing this.
Tested-by: Thierry Reding <treding@nvidia•com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-08 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:44 [PATCH net-next 0/2] fix udp pull header breakage Willem de Bruijn
2016-04-07 15:44 ` [PATCH net-next 1/2] sunrpc: do not pull udp headers on receive Willem de Bruijn
2016-04-08 7:47 ` Thierry Reding [this message]
2016-04-07 15:44 ` [PATCH net-next 2/2] rxrpc: " Willem de Bruijn
2016-04-08 7:48 ` [net-next,2/2] " Thierry Reding
2016-04-11 19:31 ` [PATCH net-next 0/2] fix udp pull header breakage David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408074740.GA30924@ulmo.ba.sec \
--to=thierry.reding@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fcooper@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=samanthakumar@google$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox