Subject: (unknown)

From: Leon Romanovsky <[email-masked]>
Date: Wed, 27 Apr 2016 09:38:25 +0300

<[email-masked]>, Doug Ledford <[email-masked]>
Bcc: 
Subject: Re: [PATCH net] RDMA/nes: don't leak skb if carrier down
Reply-To: [email-masked]
In-Reply-To: <[email-masked]>

On Sun, Apr 24, 2016 at 10:18:59PM +0200, Florian Westphal wrote:
> Alternatively one could free the skb, OTOH I don't think this test is
> useful so just remove it.
> 
> Cc: <[email-masked]>
> Signed-off-by: Florian Westphal <[email-masked]>

I don't know why did you decide to send it to netdev and not to relevant
maintainers, but the relevant mailing list is linux-rdma and Faisal
needs to Review/Acknowledge it.

➜  linux-rdma git:(master) ./scripts/get_maintainer.pl -f
drivers/infiniband/hw/nes/nes_nic.c
Faisal Latif <[email-masked]> (supporter:NETEFFECT IWARP RNIC
DRIVER (IW_NES))
Doug Ledford <[email-masked]> (supporter:INFINIBAND SUBSYSTEM)
Sean Hefty <[email-masked]> (supporter:INFINIBAND SUBSYSTEM)
Hal Rosenstock <[email-masked]> (supporter:INFINIBAND
SUBSYSTEM)
[email-masked] (open list:NETEFFECT IWARP RNIC DRIVER
(IW_NES))
[email-masked] (open list)

> ---
>  Noticed this while working on the TX_LOCKED removal.
> 
> diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
> index 3ea9e05..9291453 100644
> --- a/drivers/infiniband/hw/nes/nes_nic.c
> +++ b/drivers/infiniband/hw/nes/nes_nic.c
> @@ -500,9 +500,6 @@ static int nes_netdev_start_xmit(struct sk_buff *skb, struct net_device *netdev)
>  	 *		skb_shinfo(skb)->nr_frags, skb_is_gso(skb));
>  	 */
>  
> -	if (!netif_carrier_ok(netdev))
> -		return NETDEV_TX_OK;
> -
>  	if (netif_queue_stopped(netdev))
>  		return NETDEV_TX_BUSY;
>  
> -- 
> 2.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html