Subject: Re: [PATCH net-next 05/13] fou: Add encap ops for IPv6 tunnels

From: Shmulik Ladkani <[email-masked]>
Date: Thu, 12 May 2016 22:26:28 +0300

Hi,

On Wed, 11 May 2016 09:47:25 -0700 Tom Herbert <[email-masked]> wrote:
> This patch adds IP tunnel encapsulation operations for IPv6. This
> includes the infrastructure to add and delete operations. IPv6 variants
> of fou6_build_header and gue6_build_header are added in a new
> fou6 module. These encapsulation operations for fou and gue are
> automatically added when the fou6 module loads.

One small nit:

> +EXPORT_SYMBOL(fou6_build_header);

[snip]

> +EXPORT_SYMBOL(gue6_build_header);

As with previous patch, seems these needn't be exported. Am I missing
something here?

Reviewed-by: Shmulik Ladkani <[email-masked]>

Regards,
Shmulik