Subject: Re: [PATCH net-next] tuntap: introduce tx skb ring

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 18 May 2016 10:16:31 +0200

On Tue, 17 May 2016 09:38:37 +0800 Jason Wang <[email-masked]> wrote:

> >> And if tx_queue_length is not power of 2,
> >> we probably need modulus to calculate the capacity.  
> > Is that really that important for speed?  
> 
> Not sure, I can test.

In my experience, yes, adding a modulus does affect performance.

> > If yes, round it up to next power of two.  
> 
> Right, this sounds a good solution.

Good idea.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer