From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
vivien.didelot@savoirfairelinux•com, john@phrozen•org
Subject: Re: [PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree
Date: Mon, 6 Jun 2016 04:40:05 +0200 [thread overview]
Message-ID: <20160606024005.GJ12165@lunn.ch> (raw)
In-Reply-To: <5754A7AD.1020208@gmail.com>
On Sun, Jun 05, 2016 at 03:29:01PM -0700, Florian Fainelli wrote:
> Le 04/06/2016 13:38, Andrew Lunn a écrit :
> >> index e8386157de30..938262010524 100644
> >> --- a/net/dsa/dsa2.c
> >> +++ b/net/dsa/dsa2.c
> >> @@ -346,7 +346,7 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, struct dsa_switch *ds)
> >> continue;
> >> }
> >>
> >> - return 0;
> >> + return dsa_cpu_port_ethtool_setup(dst, ds);
> >
> > Hi Florian
> >
> > This is wrong. Remember, multiple CPU ports. You need to apply this to
> > each CPU port.
>
> We do not quite support that properly though, we still do not create a
> "cpu" network device, and there is only a single master netdev per
> dsa_switch at the moment, making the secondary CPU port interfaces
> impossible to overlay their backing "master" netdev with their companion
> switch port statistics at the moment.
Hi Florian.
Using that argument, you should probably call
dsa_cpu_port_ethtool_setup() in dsa_dst_apply, since that is what
manipulates the master interface to make it handle DSA frames.
Andrew
next prev parent reply other threads:[~2016-06-06 2:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 0:05 [PATCH net-next 0/9] net: dsa: misc improvements Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next 1/9] net: dsa: Prepare to support legacy DT binding Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next] net: dsa: Provide CPU port statistics to master netdev Florian Fainelli
2016-06-04 0:06 ` Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations Florian Fainelli
2016-06-04 0:06 ` Florian Fainelli
2016-06-06 13:30 ` Vivien Didelot
2016-06-04 0:05 ` [PATCH net-next 2/9] net: dsa: Add support for parsing the old binding Florian Fainelli
2016-06-04 19:44 ` Andrew Lunn
2016-06-04 20:00 ` Andrew Lunn
2016-06-05 22:42 ` Florian Fainelli
2016-06-06 3:19 ` Andrew Lunn
2016-06-06 20:13 ` Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next 3/9] net: dsa: Provide unique DSA slave MII bus names Florian Fainelli
2016-06-04 20:00 ` Andrew Lunn
2016-06-06 13:36 ` Vivien Didelot
2016-06-04 0:05 ` [PATCH net-next 4/9] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask Florian Fainelli
2016-06-04 20:29 ` Andrew Lunn
2016-06-05 22:38 ` Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next 5/9] net: dsa: Export suspend/resume functions Florian Fainelli
2016-06-04 20:30 ` Andrew Lunn
2016-06-06 13:40 ` Vivien Didelot
2016-06-04 0:05 ` [PATCH net-next 6/9] net: dsa: Add initialization helper for CPU port ethtool_ops Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next 6/7] net: dsa: bcm_sf2: Make it a real platform device driver Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree Florian Fainelli
2016-06-04 20:38 ` Andrew Lunn
2016-06-05 22:29 ` Florian Fainelli
2016-06-06 2:40 ` Andrew Lunn [this message]
2016-06-04 0:05 ` [PATCH net-next 7/7] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli
2016-06-04 20:49 ` Andrew Lunn
2016-06-04 0:05 ` [PATCH net-next 8/9] net: dsa: bcm_sf2: Make it a real platform device driver Florian Fainelli
2016-06-04 20:55 ` Andrew Lunn
2016-06-05 22:30 ` Florian Fainelli
2016-06-04 0:05 ` [PATCH net-next 9/9] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli
2016-06-04 0:10 ` [PATCH net-next 0/9] net: dsa: misc improvements Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606024005.GJ12165@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox