From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
vivien.didelot@savoirfairelinux•com
Subject: Re: [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree
Date: Wed, 8 Jun 2016 00:24:12 +0200 [thread overview]
Message-ID: <20160607222412.GG28994@lunn.ch> (raw)
In-Reply-To: <5757470F.7090304@gmail.com>
On Tue, Jun 07, 2016 at 03:13:35PM -0700, Florian Fainelli wrote:
> On 06/07/2016 02:51 PM, Andrew Lunn wrote:
> >> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst,
> >> + struct dsa_switch *ds)
> >> +{
> >> + struct net_device *master;
> >> + struct ethtool_ops *cpu_ops;
> >> +
> >> + master = ds->dst->master_netdev;
> >
> > You pass in dst as a parameter, and then don't use it!
>
> I do use it here:
>
> memcpy(&dst->master_ethtool_ops, master->ethtool_ops,
> sizeof(struct ethtool_ops));
Yes, i noticed this. I also expect the compiler has also noticed, and
has optimized away one of the parameters.
> I sure could simplify that and use ds->dst instead if you find it more
> elegant, works for me.
I would prefer the code to be consistent. Either use ds->dst
everywhere and drop the parameter, or use the parameter everywhere it
is usable.
Thanks
Andrew
next prev parent reply other threads:[~2016-06-07 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 21:06 [PATCH net-next v3 0/6] net: dsa: misc improvements Florian Fainelli
2016-06-07 21:06 ` [PATCH net-next v3 1/6] net: dsa: Provide unique DSA slave MII bus names Florian Fainelli
2016-06-07 21:06 ` [PATCH net-next v3 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask Florian Fainelli
2016-06-07 21:32 ` Andrew Lunn
2016-06-07 21:06 ` [PATCH net-next v3 3/6] net: dsa: Provide a slave MII bus if needed Florian Fainelli
2016-06-07 21:40 ` Andrew Lunn
2016-06-07 22:52 ` Vivien Didelot
2016-06-07 21:06 ` [PATCH net-next v3 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops Florian Fainelli
2016-06-07 22:54 ` Vivien Didelot
2016-06-07 21:06 ` [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree Florian Fainelli
2016-06-07 21:51 ` Andrew Lunn
2016-06-07 22:13 ` Florian Fainelli
2016-06-07 22:24 ` Andrew Lunn [this message]
2016-06-07 21:06 ` [PATCH net-next v3 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607222412.GG28994@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox