Subject: Re: [PATCH net-next 1/5] net: dsa: b53: Add support for Broadcom RoboSwitch

From: Andrew Lunn <[email-masked]>
Date: Fri, 10 Jun 2016 20:57:20 +0200

> >> +static inline int b53_switch_get_reset_gpio(struct b53_device *dev)
> >> +{
> >> +	enum bcm47xx_board board = bcm47xx_board_get();
> >> +
> >> +	switch (board) {
> >> +	case BCM47XX_BOARD_LINKSYS_WRT300NV11:
> >> +	case BCM47XX_BOARD_LINKSYS_WRT310NV1:
> >> +		return 8;
> > 
> > Rather than hard coding it, could we get it from device tree?
> 
> Difficult for now, this is for in-tree MIPS-based platforms under
> arch/mips/bcm47xx, which are using SSB/platform data.

Ah, O.K.

But it would not harm to also support getting the GPIO from device
tree, if device tree is available. But maybe that should wait until
such a user comes along.

     Andrew